ESLint v10 support

.github/workflows/eslint-8+.yml

@@ -36,9 +36,18 @@ jobs:
           - macos-latest
         node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
         eslint:
+          - 10
           - 9
           - 8
         exclude:
+          - node-version: 17
+            eslint: 10
+          - node-version: 16
+            eslint: 10
+          - node-version: 14
+            eslint: 10
+          - node-version: 12
+            eslint: 10
           - node-version: 16
             eslint: 9
           - node-version: 14

package.json

@@ -81,7 +81,7 @@
     "chai": "^4.3.10",
     "cross-env": "^4.0.0",
     "escope": "^3.6.0",
-    "eslint": "^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8 || ^9",
+    "eslint": "^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8 || ^9 || ^10",
     "eslint-doc-generator": "^1.6.1",
     "eslint-import-resolver-node": "file:./resolvers/node",
     "eslint-import-resolver-typescript": "^1.0.2 || ^1.1.1",
@@ -91,6 +91,8 @@
     "eslint-plugin-eslint-plugin": "^2.3.0",
     "eslint-plugin-import": "2.x",
     "eslint-plugin-json": "^2.1.2",
+    "eslint-plugin-jsonc": "^2.21.1",
+    "espree": "^9",
     "find-babel-config": "=1.2.0",
     "fs-copy-file-sync": "^1.1.1",
     "glob": "^7.2.3",
@@ -112,7 +114,7 @@
     "typescript-eslint-parser": "^15 || ^20 || ^22"
   },
   "peerDependencies": {
-    "eslint": "^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8 || ^9"
+    "eslint": "^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8 || ^9 || ^10"
   },
   "dependencies": {
     "@rtsao/scc": "^1.1.0",

src/core/sourceType.js

@@ -3,10 +3,10 @@
  * @returns 'module' | 'script' | 'commonjs' | undefined
  */
 export default function sourceType(context) {
-  if ('sourceType' in context.parserOptions) {
-    return context.parserOptions.sourceType;
-  }
   if ('languageOptions' in context && context.languageOptions) {
     return context.languageOptions.sourceType;
   }
+  if (context.parserOptions && 'sourceType' in context.parserOptions) {
+    return context.parserOptions.sourceType;
+  }
 }

src/exportMap/childContext.js

@@ -48,7 +48,7 @@ export default function childContext(path, context) {
   return {
     cacheKey: optionsToken + settingsHash + String(path),
     settings,
-    parserOptions,
+    parserOptions: parserOptions || languageOptions && languageOptions.parserOptions,
     parserPath,
     path,
     languageOptions,

src/exportMap/specifier.js

@@ -14,7 +14,9 @@ export default function processSpecifier(specifier, astNode, exportMap, namespac
       }));
       return;
     case 'ExportAllDeclaration':
-      exportMap.namespace.set(specifier.exported.name || specifier.exported.value, namespace.add(exportMeta, specifier.source.value));
+      exportMap.namespace.set(specifier.exported.name || specifier.exported.value, Object.defineProperty(exportMeta, 'namespace', {
+        get() { return namespace.resolveImport(specifier.source.value); },
+      }));
       return;
     case 'ExportSpecifier':
       if (!astNode.source) {

src/exportMap/typescript.js

@@ -7,7 +7,10 @@ const tsconfigCache = new Map();
 
 function readTsConfig(context) {
   const tsconfigInfo = tsConfigLoader({
-    cwd: context.parserOptions && context.parserOptions.tsconfigRootDir || process.cwd(),
+    cwd: (context.parserOptions
+      ? context.parserOptions.tsconfigRootDir
+      : context.languageOptions && context.languageOptions.parserOptions && context.languageOptions.parserOptions.tsconfigRootDir
+    ) || process.cwd(),
     getEnv: (key) => process.env[key],
   });
   try {
@@ -31,7 +34,9 @@ function readTsConfig(context) {
 
 export function isEsModuleInterop(context) {
   const cacheKey = hashObject({
-    tsconfigRootDir: context.parserOptions && context.parserOptions.tsconfigRootDir,
+    tsconfigRootDir: context.parserOptions
+      ? context.parserOptions.tsconfigRootDir
+      : context.languageOptions && context.languageOptions.parserOptions && context.languageOptions.parserOptions.tsconfigRootDir,
   }).digest('hex');
   let tsConfig = tsconfigCache.get(cacheKey);
   if (typeof tsConfig === 'undefined') {

src/exportMap/visitor.js

@@ -57,9 +57,12 @@ export default class ImportExportVisitorBuilder {
       },
       ExportAllDeclaration() {
         const getter = captureDependency(astNode, astNode.exportKind === 'type', this.remotePathResolver, this.exportMap, this.context, this.thunkFor);
-        if (getter) { this.exportMap.dependencies.add(getter); }
         if (astNode.exported) {
+          // `export * as ns from './mod'` — named namespace, not a star-export
           processSpecifier(astNode, astNode.exported, this.exportMap, this.namespace);
+        } else if (getter) {
+          // `export * from './mod'` — star-export flattens into current module
+          this.exportMap.dependencies.add(getter);
         }
       },
       /** capture namespaces in case of later export */

src/rules/no-unused-modules.js

@@ -13,6 +13,7 @@ import readPkgUp from 'eslint-module-utils/readPkgUp';
 import values from 'object.values';
 import includes from 'array-includes';
 import flatMap from 'array.prototype.flatmap';
+import minimatch from 'minimatch';
 
 import ExportMapBuilder from '../exportMap/builder';
 import recursivePatternCapture from '../exportMap/patternCapture';
@@ -147,6 +148,86 @@ function listFilesWithLegacyFunctions(src, extensions) {
   }
 }
 
+/**
+ * Walk a directory recursively, collecting file paths that match the given extensions.
+ * Skips node_modules and dot-directories.
+ * @param {string} dir - directory to walk
+ * @param {string[]} extensions - list of supported file extensions
+ * @param {string[]} results - accumulator for matched file paths
+ * @param {object} fs - Node.js fs module
+ * @param {Function} join - path.join
+ * @param {Function} extname - path.extname
+ * @returns {string[]} list of matched file paths
+ */
+function walkDirectory(dir, extensions, results, fs, join, extname) {
+  let entries;
+  try {
+    entries = fs.readdirSync(dir, { withFileTypes: true });
+  } catch (e) {
+    return results;
+  }
+
+  for (let i = 0; i < entries.length; i++) {
+    const entry = entries[i];
+    if (entry.name[0] === '.' || entry.name === 'node_modules') {
+      continue;
+    }
+    const fullPath = join(dir, entry.name);
+    if (entry.isDirectory()) {
+      walkDirectory(fullPath, extensions, results, fs, join, extname);
+    } else if (entry.isFile() && extensions.indexOf(extname(fullPath)) > -1) {
+      results.push(fullPath);
+    }
+  }
+
+  return results;
+}
+
+/**
+ * List files using Node.js fs and minimatch as a fallback when FileEnumerator
+ * and legacy ESLint APIs are unavailable (ESLint v10+).
+ * @param {string[]} src - list of file paths, directories, or glob patterns
+ * @param {string[]} extensions - list of supported file extensions
+ * @returns {string[]} list of matched file paths
+ */
+function listFilesWithNodeFs(src, extensions) {
+  const fs = require('fs');
+  const { join, resolve, extname } = require('path');
+  const isGlob = require('is-glob');
+
+  extensions = extensions.map((ext) => ext.startsWith('.') ? ext : `.${ext}`);
+  const results = [];
+
+  src.forEach((pattern) => {
+    if (isGlob(pattern)) {
+      // For glob patterns, walk the base directory and filter with minimatch
+      // Extract the base directory from the glob (everything before the first glob character)
+      const base = pattern.replace(/[*?{[].*/g, '').replace(/\/[^/]*$/, '') || '.';
+      const resolvedBase = resolve(base);
+      const allFiles = walkDirectory(resolvedBase, extensions, [], fs, join, extname);
+      allFiles.forEach((file) => {
+        if (minimatch(file, resolve(pattern)) || minimatch(file, pattern)) {
+          results.push(file);
+        }
+      });
+    } else {
+      const resolved = resolve(pattern);
+      try {
+        const stat = fs.statSync(resolved);
+        if (stat.isDirectory()) {
+          walkDirectory(resolved, extensions, results, fs, join, extname);
+        } else if (stat.isFile() && extensions.indexOf(extname(resolved)) > -1) {
+          results.push(resolved);
+        }
+      } catch (e) {
+        // Path doesn't exist, skip it
+      }
+    }
+  });
+
+  return results;
+}
+
 /**
  * Given a src pattern and list of supported extensions, return a list of files to process
  * with this rule.
@@ -162,7 +243,15 @@ function listFilesToProcess(src, extensions) {
     return listFilesUsingFileEnumerator(FileEnumerator, src, extensions);
   }
   // If not, then we can try even older versions of this capability (listFilesToProcess)
-  return listFilesWithLegacyFunctions(src, extensions);
+  try {
+    return listFilesWithLegacyFunctions(src, extensions);
+  } catch (e) {
+    // If legacy functions are also unavailable (ESLint v10+), use Node.js fs as a fallback
+    if (e.code === 'MODULE_NOT_FOUND' || e.code === 'ERR_PACKAGE_PATH_NOT_EXPORTED') {
+      return listFilesWithNodeFs(src, extensions);
+    }
+    throw e;
+  }
 }
 
 const EXPORT_DEFAULT_DECLARATION = 'ExportDefaultDeclaration';

src/rules/order.js

@@ -24,11 +24,23 @@ function reverse(array) {
   return array.map((v) => ({ ...v, rank: -v.rank })).reverse();
 }
 
+function getTokenOrCommentAfterCompat(sourceCode, nodeOrToken) {
+  return sourceCode.getTokenOrCommentAfter
+    ? sourceCode.getTokenOrCommentAfter(nodeOrToken)
+    : sourceCode.getTokenAfter(nodeOrToken, { includeComments: true });
+}
+
+function getTokenOrCommentBeforeCompat(sourceCode, nodeOrToken) {
+  return sourceCode.getTokenOrCommentBefore
+    ? sourceCode.getTokenOrCommentBefore(nodeOrToken)
+    : sourceCode.getTokenBefore(nodeOrToken, { includeComments: true });
+}
+
 function getTokensOrCommentsAfter(sourceCode, node, count) {
   let currentNodeOrToken = node;
   const result = [];
   for (let i = 0; i < count; i++) {
-    currentNodeOrToken = sourceCode.getTokenOrCommentAfter(currentNodeOrToken);
+    currentNodeOrToken = getTokenOrCommentAfterCompat(sourceCode, currentNodeOrToken);
     if (currentNodeOrToken == null) {
       break;
     }
@@ -41,7 +53,7 @@ function getTokensOrCommentsBefore(sourceCode, node, count) {
   let currentNodeOrToken = node;
   const result = [];
   for (let i = 0; i < count; i++) {
-    currentNodeOrToken = sourceCode.getTokenOrCommentBefore(currentNodeOrToken);
+    currentNodeOrToken = getTokenOrCommentBeforeCompat(sourceCode, currentNodeOrToken);
     if (currentNodeOrToken == null) {
       break;
     }

src/scc.js

@@ -20,8 +20,9 @@ export default class StronglyConnectedComponentsBuilder {
   static for(context) {
     const settingsHash = hashObject({
       settings: context.settings,
-      parserOptions: context.parserOptions,
+      parserOptions: context.parserOptions || context.languageOptions && context.languageOptions.parserOptions,
       parserPath: context.parserPath,
+      languageOptions: context.languageOptions,
     }).digest('hex');
     const cacheKey = context.path + settingsHash;
     if (cache.has(cacheKey)) {

tests/dep-time-travel.sh

@@ -58,3 +58,25 @@ if [ "${ESLINT_VERSION}" = '8' ]; then
   echo "Build self"
   npm run build
 fi
+
+# ESLint 10 requires newer parsers
+if [[ "$ESLINT_VERSION" -ge "10" ]]; then
+  echo "Installing @typescript-eslint/parser v8 for ESLint 10..."
+  npm i --no-save @typescript-eslint/parser@8
+
+  echo "Installing @angular-eslint/template-parser v21.3.0+ for ESLint 10..."
+  npm i --no-save '@angular-eslint/template-parser@^21.3.0'
+
+  # @babel/eslint-parser v8 requires Node ^20.19.0 || >=22.12.0; v7 doesn't support ESLint 10
+  if [[ "$TRAVIS_NODE_VERSION" -eq "20" ]] || [[ "$TRAVIS_NODE_VERSION" -ge "22" ]]; then
+    echo "Installing @babel/eslint-parser v8 for ESLint 10..."
+    npm i --no-save @babel/core@'^8.0.0-rc.2' @babel/eslint-parser@'^8.0.0-rc.2'
+  fi
+
+  # eslint-plugin-jsonc v3 supports ESLint 10; v2 (the default in package.json) does not.
+  # v3 requires Node ^20.19.0 || ^22.13.0 || >=24 — install only on supported Node majors.
+  if [[ "$TRAVIS_NODE_VERSION" -eq "20" ]] || [[ "$TRAVIS_NODE_VERSION" -eq "22" ]] || [[ "$TRAVIS_NODE_VERSION" -ge "24" ]]; then
+    echo "Installing eslint-plugin-jsonc v3 for ESLint 10..."
+    npm i --no-save eslint-plugin-jsonc@^3
+  fi
+fi

tests/files/just-json-files/eslint.config.mjs

@@ -0,0 +1,17 @@
+import jsoncPlugin from 'eslint-plugin-jsonc';
+
+export default [
+  ...jsoncPlugin.configs['flat/recommended-with-json'],
+  {
+    files: ['tests/files/just-json-files/*.json'],
+    rules: {
+      'import/no-unused-modules': [
+        'error',
+        {
+          missingExports: false,
+          unusedExports: true,
+        },
+      ],
+    },
+  },
+];