Disallow session closure for Cambridge Audio#171036
Draft
noahhusby wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Bumps the aiostreammagic library from 2.13.0 to 2.13.1 and updates the Cambridge Audio integration to pass the new should_close_session=False argument when constructing the client with a shared Home Assistant session.
Changes:
- Update
aiostreammagicdependency to 2.13.1 in manifest and requirements files. - Pass
should_close_session=FalsetoStreamMagicClientto prevent closing the shared aiohttp session.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements_test_all.txt | Bumped aiostreammagic to 2.13.1. |
| requirements_all.txt | Bumped aiostreammagic to 2.13.1. |
| homeassistant/components/cambridge_audio/manifest.json | Bumped aiostreammagic requirement to 2.13.1. |
| homeassistant/components/cambridge_audio/init.py | Pass should_close_session=False when creating StreamMagicClient with the shared session. |
erwindouna
requested changes
May 18, 2026
| "loggers": ["aiostreammagic"], | ||
| "quality_scale": "platinum", | ||
| "requirements": ["aiostreammagic==2.13.0"], | ||
| "requirements": ["aiostreammagic==2.13.1"], |
Member
There was a problem hiding this comment.
You're bringing in a dependency upgrade. Please provide a changelog and/or diff comparison. :)
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Passes flag to Cambridge Audio upstream library indicating that the provided session should not be closed.
Depends on: #171035
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: