Add stop command to Overkiz pergola horizontal awning covers#171034
Merged
Conversation
Contributor
|
Hey there @iMicknl, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing stop_command=OverkizCommand.STOP to the PergolaHorizontalAwning and PergolaHorizontalAwningUno cover entity descriptions in the Overkiz integration, restoring the stop button that disappeared after the entity description migration in #141330.
Changes:
- Add
stop_command=OverkizCommand.STOPto thePergolaHorizontalAwningdescription. - Add
stop_command=OverkizCommand.STOPto thePergolaHorizontalAwningUnodescription.
Member
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The
PergolaHorizontalAwningandPergolaHorizontalAwningUnocover entity descriptions are missingstop_command, so the stop button doesn't appear in the UI. Other similar cover types (roller shutters, venetian blinds, dual roller shutters) all havestop_command=OverkizCommand.STOPset.This is a regression from the entity description migration (#141330) - the old code path had stop enabled by default but the migration didn't carry it over for these two cover types.
The
stop_commandis only used if the device actually reports supporting the STOP command (checked at runtime viaexecutor.has_command), so this is safe to add.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: