Skip to content

Add stop command to Overkiz pergola horizontal awning covers#171034

Merged
iMicknl merged 1 commit into
devfrom
frenck-2026-0586
May 18, 2026
Merged

Add stop command to Overkiz pergola horizontal awning covers#171034
iMicknl merged 1 commit into
devfrom
frenck-2026-0586

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 17, 2026

Proposed change

The PergolaHorizontalAwning and PergolaHorizontalAwningUno cover entity descriptions are missing stop_command, so the stop button doesn't appear in the UI. Other similar cover types (roller shutters, venetian blinds, dual roller shutters) all have stop_command=OverkizCommand.STOP set.

This is a regression from the entity description migration (#141330) - the old code path had stop enabled by default but the migration didn't carry it over for these two cover types.

The stop_command is only used if the device actually reports supporting the STOP command (checked at runtime via executor.has_command), so this is safe to add.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 17, 2026 21:29
@frenck frenck requested a review from iMicknl as a code owner May 17, 2026 21:29
@home-assistant home-assistant Bot added bugfix cla-signed integration: overkiz small-pr PRs with less than 30 lines. Top 200 Integration is ranked within the top 200 by usage labels May 17, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @iMicknl, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of overkiz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign overkiz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing stop_command=OverkizCommand.STOP to the PergolaHorizontalAwning and PergolaHorizontalAwningUno cover entity descriptions in the Overkiz integration, restoring the stop button that disappeared after the entity description migration in #141330.

Changes:

  • Add stop_command=OverkizCommand.STOP to the PergolaHorizontalAwning description.
  • Add stop_command=OverkizCommand.STOP to the PergolaHorizontalAwningUno description.

@frenck frenck added this to the 2026.5.3 milestone May 17, 2026
@iMicknl
Copy link
Copy Markdown
Member

iMicknl commented May 17, 2026

@frenck thanks again! This change is also part of #170983 by the way. Do you want this specific change in a separate PR?

@iMicknl iMicknl merged commit 0eecb03 into dev May 18, 2026
34 checks passed
@iMicknl iMicknl deleted the frenck-2026-0586 branch May 18, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix cla-signed integration: overkiz Quality Scale: No score small-pr PRs with less than 30 lines. Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop button missing for PergolaHorizontalAwning covers in Overkiz

4 participants