Skip to content

Add additional overrides to cover entity in Overkiz#171019

Merged
zweckj merged 4 commits into
home-assistant:devfrom
iMicknl:overkiz/fix-pedestrian-gate-overrides
May 18, 2026
Merged

Add additional overrides to cover entity in Overkiz#171019
zweckj merged 4 commits into
home-assistant:devfrom
iMicknl:overkiz/fix-pedestrian-gate-overrides

Conversation

@iMicknl
Copy link
Copy Markdown
Member

@iMicknl iMicknl commented May 17, 2026

Proposed change

Based on the available UIWidgets, adding additional overrides for the "withPedestrianPosition" devices. Add tilt support to the Roller Shutter.

Unfortunately I haven't been able to find device fixtures for these specific devices, but they are very similar to previous implementations / bugfixes after the large cover entity rewrite.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

iMicknl added 4 commits May 17, 2026 19:13
Add cover descriptions for OpenCloseGateWithPedestrianPosition,
OpenCloseSlidingGateWithPedestrianPosition, and
PositionableGateWithPedestrianPosition widgets which report
core:OpenClosedPedestrianState instead of core:OpenClosedState.
Add cover descriptions for PositionableOrOrientableRollerShutter and
PositionableOrProgressiveOrientableRollerShutter widgets which support
tilt via core:SlateOrientationState and setOrientation, not provided
by the UIClass.ROLLER_SHUTTER fallback.
Add core:SlateOrientationState and setOrientation tilt fields to the
RollerShutter UIClass description. Tilt is only exposed when a device
actually supports the setOrientation command, so this is safe for
standard roller shutters without orientation capability.
@iMicknl iMicknl added this to the 2026.5.3 milestone May 17, 2026
Copilot AI review requested due to automatic review settings May 17, 2026 19:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Overkiz cover entity descriptions for three additional gate widgets that report core:OpenClosedPedestrianState (so they need the same override as the existing OPEN_CLOSE_PEDESTRIAN_GATE), and adds tilt (slate orientation) support to the generic ROLLER_SHUTTER description.

Changes:

  • Add OverkizCoverDescription overrides for OPEN_CLOSE_GATE_WITH_PEDESTRIAN_POSITION, OPEN_CLOSE_SLIDING_GATE_WITH_PEDESTRIAN_POSITION, and POSITIONABLE_GATE_WITH_PEDESTRIAN_POSITION widgets (Gate device class, pedestrian closed-state).
  • Include current_position_state/set_position_command for the positionable variant only.
  • Extend the UIClass.ROLLER_SHUTTER description with current_tilt_position_state, set_tilt_position_command, and stop_tilt_command (gated at runtime by executor.has_command).

@zweckj zweckj merged commit 0c22c13 into home-assistant:dev May 18, 2026
33 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants