Skip to content

Replace redacted labels in test fixtures with meaningful names in overkiz#170988

Merged
justanotherariel merged 1 commit into
home-assistant:devfrom
iMicknl:fix-overkiz-fixture-labels
May 18, 2026
Merged

Replace redacted labels in test fixtures with meaningful names in overkiz#170988
justanotherariel merged 1 commit into
home-assistant:devfrom
iMicknl:fix-overkiz-fixture-labels

Conversation

@iMicknl
Copy link
Copy Markdown
Member

@iMicknl iMicknl commented May 17, 2026

Proposed change

The fixture files had device labels obfuscated with asterisk patterns from pyoverkiz's obfuscate_string function. Replace these with descriptive names based on device type (gateway pods, protocol stacks, sensors, speakers, etc.) to improve test readability, and match the real-world.

Also replaces redacted core:NameState values and HomeKit setup codes with realistic fake values.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

The fixture files had device labels obfuscated with asterisk patterns
from pyoverkiz's obfuscate_string function. Replace these with
descriptive names based on device type (gateway pods, protocol stacks,
sensors, speakers, etc.) to improve test readability.

Also replaces redacted core:NameState values and HomeKit setup codes
with realistic fake values.
Copilot AI review requested due to automatic review settings May 17, 2026 15:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Overkiz test fixtures and snapshots to replace previously obfuscated device labels/NameState values with descriptive, realistic names to improve test readability.

Changes:

  • Replace asterisk-obfuscated label and core:NameState values in multiple Overkiz setup fixtures with meaningful device names.
  • Replace redacted HomeKit setup payload/code strings with realistic fake values in relevant fixtures.
  • Update Overkiz button snapshot expectations (test_button.ambr) to match the renamed devices/entities.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/components/overkiz/snapshots/test_button.ambr Updates entity registry/state snapshots to reflect the new descriptive device names and resulting entity IDs/unique IDs.
tests/components/overkiz/fixtures/setup/local_somfy_tahoma_v2_europe.json Replaces obfuscated gateway/alarm/light labels and core:NameState values with descriptive names.
tests/components/overkiz/fixtures/setup/local_somfy_tahoma_switch_europe.json Replaces obfuscated TaHoma gateway/stack labels and core:NameState values with descriptive names.
tests/components/overkiz/fixtures/setup/local_somfy_tahoma_switch_europe_2.json Replaces obfuscated TaHoma/Zigbee-related labels and core:NameState values with descriptive names.
tests/components/overkiz/fixtures/setup/local_somfy_connexoon_europe.json Replaces obfuscated Connexoon labels and core:NameState values with descriptive names.
tests/components/overkiz/fixtures/setup/cloud_somfy_tahoma_v2_europe.json Replaces obfuscated cloud device labels/NameState values (and HomeKit setup strings) with descriptive names.
tests/components/overkiz/fixtures/setup/cloud_somfy_tahoma_switch_sc_europe.json Replaces obfuscated cloud TaHoma Switch labels/NameState values and HomeKit setup strings with descriptive names.
tests/components/overkiz/fixtures/setup/cloud_somfy_connexoon_rts_asia.json Replaces obfuscated Connexoon labels and core:NameState values with descriptive names.

Copy link
Copy Markdown
Member

@justanotherariel justanotherariel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iMicknl

@justanotherariel justanotherariel merged commit ba5a62e into home-assistant:dev May 18, 2026
33 checks passed
@iMicknl iMicknl deleted the fix-overkiz-fixture-labels branch May 18, 2026 09:27
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants