Skip to content

Fix controls for OpenCloseGate4T (rts:GateOpenerRTS4TComponent) in Overkiz#170987

Merged
iMicknl merged 5 commits into
home-assistant:devfrom
iMicknl:fix-overkiz-open-close-gate-4t
May 18, 2026
Merged

Fix controls for OpenCloseGate4T (rts:GateOpenerRTS4TComponent) in Overkiz#170987
iMicknl merged 5 commits into
home-assistant:devfrom
iMicknl:fix-overkiz-open-close-gate-4t

Conversation

@iMicknl
Copy link
Copy Markdown
Member

@iMicknl iMicknl commented May 17, 2026

Proposed change

Fix controls for the OpenCloseGate4T widget (rts:GateOpenerRTS4TComponent) in the Overkiz integration. This device only supports a cycle command — not the standard open/close/stop commands expected by the UIClass.GATE default. Without a dedicated widget override, the entity has zero supported features and becomes unusable.

This adds a widget override that maps cycle as both the open and close command, restoring toggle functionality for these RTS gate openers.

Fixes #170214

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

iMicknl added 3 commits May 16, 2026 15:45
The OpenCloseGate4T widget (rts:GateOpenerRTS4TComponent) only supports
a cycle command—not the standard open/close/stop commands expected by
the UIClass.GATE default. Without a dedicated override, the entity got
zero supported features and became unusable after the 2026.5 rewrite.

Add a widget override that maps cycle as the open command, restoring
the toggle functionality for these RTS gate openers.

Fixes home-assistant#170214
…-gate-4t

# Conflicts:
#	homeassistant/components/overkiz/cover.py
#	tests/components/overkiz/fixtures/setup/cloud_somfy_tahoma_v2_europe.json
#	tests/components/overkiz/test_cover.py
@iMicknl iMicknl added this to the 2026.5.3 milestone May 17, 2026
Copilot AI review requested due to automatic review settings May 17, 2026 14:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores functionality for Somfy RTS OpenCloseGate4T (rts:GateOpenerRTS4TComponent) covers in the Overkiz integration. Because this widget only exposes the cycle command, the default Gate UI class produced an entity with no supported features. The PR adds a dedicated widget override that maps both open and close to the cycle command, plus a fixture device and tests covering the new behaviour.

Changes:

  • Add an OverkizCoverDescription override for UIWidget.OPEN_CLOSE_GATE_4T mapping open/close to OverkizCommand.CYCLE.
  • Add an RTS gate device fixture entry to cloud_somfy_tahoma_v2_europe.json.
  • Add cover entity/action tests, button snapshot, and cover snapshot for the new device.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/overkiz/cover.py Adds widget override mapping cycle to both open/close commands for the RTS 4T gate opener.
tests/components/overkiz/fixtures/setup/cloud_somfy_tahoma_v2_europe.json Adds an OpenCloseGate4T device for use in fixture-based tests.
tests/components/overkiz/test_cover.py Adds the RTS gate device and open/close action parametrizations expecting cycle with RTS auto-appended [0] parameter.
tests/components/overkiz/snapshots/test_cover.ambr Snapshot for the new cover entity (supported features = open
tests/components/overkiz/snapshots/test_button.ambr Snapshot for the auto-generated cycle Toggle button entity.

@iMicknl iMicknl marked this pull request as ready for review May 17, 2026 16:04
…gGateOpener, CyclicSlidingGateOpener)

These devices only support the cycle command instead of separate open/close
commands. Without explicit widget overrides, they fall through to their
UIClass default which expects open/close/stop commands, resulting in no
supported features and a non-functional entity.
Copy link
Copy Markdown
Member

@justanotherariel justanotherariel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It would be nice to further extend test_cover_service_actions to also test CYCLIC_SLIDING_GATE_OPENER (since that is the only one not tested).

Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a merge conflict, can you take a look?

@home-assistant home-assistant Bot marked this pull request as draft May 18, 2026 09:50
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

…se-gate-4t

# Conflicts:
#	tests/components/overkiz/snapshots/test_button.ambr
Copilot AI review requested due to automatic review settings May 18, 2026 10:15
@iMicknl
Copy link
Copy Markdown
Member Author

iMicknl commented May 18, 2026

@justanotherariel unfortunately I don't have any user with this device and thus no real fixture. We don't try to build our own synthetic fixtures, as they are often slightly different to real world devices... That's the reason we have not included this specific device in our test suite (yet).

@iMicknl iMicknl marked this pull request as ready for review May 18, 2026 10:16
@home-assistant home-assistant Bot requested a review from joostlek May 18, 2026 10:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment thread homeassistant/components/overkiz/cover.py
Copy link
Copy Markdown
Member

@justanotherariel justanotherariel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iMicknl

@iMicknl iMicknl merged commit 7c9b6ad into home-assistant:dev May 18, 2026
33 checks passed
jnimmo pushed a commit to jnimmo/core that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Controls are non functional for OpenCloseGate4T (rts:GateOpenerRTS4TComponent) after 2026.5 in Overkiz

4 participants