Fix controls for OpenCloseGate4T (rts:GateOpenerRTS4TComponent) in Overkiz#170987
Conversation
The OpenCloseGate4T widget (rts:GateOpenerRTS4TComponent) only supports a cycle command—not the standard open/close/stop commands expected by the UIClass.GATE default. Without a dedicated override, the entity got zero supported features and became unusable after the 2026.5 rewrite. Add a widget override that maps cycle as the open command, restoring the toggle functionality for these RTS gate openers. Fixes home-assistant#170214
…-gate-4t # Conflicts: # homeassistant/components/overkiz/cover.py # tests/components/overkiz/fixtures/setup/cloud_somfy_tahoma_v2_europe.json # tests/components/overkiz/test_cover.py
There was a problem hiding this comment.
Pull request overview
This PR restores functionality for Somfy RTS OpenCloseGate4T (rts:GateOpenerRTS4TComponent) covers in the Overkiz integration. Because this widget only exposes the cycle command, the default Gate UI class produced an entity with no supported features. The PR adds a dedicated widget override that maps both open and close to the cycle command, plus a fixture device and tests covering the new behaviour.
Changes:
- Add an
OverkizCoverDescriptionoverride forUIWidget.OPEN_CLOSE_GATE_4Tmapping open/close toOverkizCommand.CYCLE. - Add an RTS gate device fixture entry to
cloud_somfy_tahoma_v2_europe.json. - Add cover entity/action tests, button snapshot, and cover snapshot for the new device.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/overkiz/cover.py | Adds widget override mapping cycle to both open/close commands for the RTS 4T gate opener. |
| tests/components/overkiz/fixtures/setup/cloud_somfy_tahoma_v2_europe.json | Adds an OpenCloseGate4T device for use in fixture-based tests. |
| tests/components/overkiz/test_cover.py | Adds the RTS gate device and open/close action parametrizations expecting cycle with RTS auto-appended [0] parameter. |
| tests/components/overkiz/snapshots/test_cover.ambr | Snapshot for the new cover entity (supported features = open |
| tests/components/overkiz/snapshots/test_button.ambr | Snapshot for the auto-generated cycle Toggle button entity. |
…gGateOpener, CyclicSlidingGateOpener) These devices only support the cycle command instead of separate open/close commands. Without explicit widget overrides, they fall through to their UIClass default which expects open/close/stop commands, resulting in no supported features and a non-functional entity.
justanotherariel
left a comment
There was a problem hiding this comment.
Looks good to me. It would be nice to further extend test_cover_service_actions to also test CYCLIC_SLIDING_GATE_OPENER (since that is the only one not tested).
joostlek
left a comment
There was a problem hiding this comment.
there's a merge conflict, can you take a look?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
…se-gate-4t # Conflicts: # tests/components/overkiz/snapshots/test_button.ambr
|
@justanotherariel unfortunately I don't have any user with this device and thus no real fixture. We don't try to build our own synthetic fixtures, as they are often slightly different to real world devices... That's the reason we have not included this specific device in our test suite (yet). |
Proposed change
Fix controls for the OpenCloseGate4T widget (rts:GateOpenerRTS4TComponent) in the Overkiz integration. This device only supports a cycle command — not the standard open/close/stop commands expected by the UIClass.GATE default. Without a dedicated widget override, the entity has zero supported features and becomes unusable.
This adds a widget override that maps cycle as both the open and close command, restoring toggle functionality for these RTS gate openers.
Fixes #170214
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: