Bump yardian to v133#170982
Conversation
There was a problem hiding this comment.
Hello @aeon-matrix,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
880c138295fe5b51c928d92cbb56728c20aaae1c- This commit has something that looks like an email address (contact@aeon-matrix.com). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @h3l1o5, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
880c138 to
f24eea9
Compare
joostlek
left a comment
There was a problem hiding this comment.
Hey so this is the 3rd PR you've opened and they all look AI generated and they all have the same issues and they have not been fixed. Please try to look into it before contuing
|
Hi @joostlek, I apologize for the frustration. I am new to the HA core
standards and have been using AI tools to help me understand the structure.
I have this running on my Yardian hardware and have fixed issues we had
previously. I have also passed hassfest, ruff, and pylint locally.
Could you please point out one or two of the 'recurring issues' you
mentioned? Thanks for your time.
…On Sun, May 17, 2026 at 10:28 PM Joost Lekkerkerker < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hey so this is the 3rd PR you've opened and they all look AI generated and
they all have the same issues and they have not been fixed. Please try to
look into it before contuing
—
Reply to this email directly, view it on GitHub
<#170982 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CDOX6KRPPOI5GA3Q2RZIE3343HEARAVCNFSM6AAAAACZBN43YWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DGMBVGU3TKMBQGU>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
You should split up PRs to well scopes PRs. Dont add new features to a dependency bump for example |
|
I'll split them and let you know when it's done.
|
|
I think I need to cancel this PR and start a new one in order to split the changes. |
|
You don't have to close this PR, you can just push changes to this PR instead |
|
OK. I will try to push so that only the following 3 files are changed.
manifest.json
requirements_all.txt
requirements_test_all.txt
…On Mon, May 18, 2026 at 3:42 AM Joost Lekkerkerker ***@***.***> wrote:
*joostlek* left a comment (home-assistant/core#170982)
<#170982 (comment)>
You don't have to close this PR, you can just push changes to this PR
instead
—
Reply to this email directly, view it on GitHub
<#170982 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CDOX6KVY5X4LTPKJWQFMYEL43IIZLAVCNFSM6AAAAACZBN43YWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DINZSGI4TEOJYGU>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I think there are only 3 files pushed to this PR for the pyyardian version change. Bump pyyardian to 1.3.3 |
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: