Fix is_closed state for DiscretePositionableGarageDoor in Overkiz#170981
Merged
zweckj merged 4 commits intoMay 18, 2026
Merged
Conversation
The DiscretePositionableGarageDoor widget (e.g. Somfy Rollixo IO) reports core:OpenClosedUnknownState instead of core:OpenClosedState and does not support position control. Without a widget-specific override, the device falls through to the UIClass.GARAGE_DOOR default which looks for wrong states, causing the cover to always report unknown state. Fixes home-assistant#170966
Restore original unicode characters that were incorrectly converted to escape sequences, and remove paramsSig fields that are not present in the cloud API format.
The diagnostics were from a local API setup, so the fixture belongs in local_somfy_tahoma_v2_europe.json with the proper local format (includes paramsSig, subsystemId, synced fields; excludes cloud-only fields).
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Overkiz cover entity mapping for Somfy Rollixo IO devices using the DiscretePositionableGarageDoor widget so the entity reports a correct is_closed state (and does not expose unsupported position control) after the cover platform migration to entity descriptions.
Changes:
- Add a widget-specific
OverkizCoverDescriptionforUIWidget.DISCRETE_POSITIONABLE_GARAGE_DOORusingcore:OpenClosedUnknownState. - Extend the Overkiz cover service-action tests to include the discrete garage door device.
- Update the local TaHoma fixture and snapshot to include and validate the new device behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/overkiz/cover.py | Adds a widget-specific override so is_closed is derived from CORE_OPEN_CLOSED_UNKNOWN and position support is not enabled. |
| tests/components/overkiz/test_cover.py | Adds the discrete garage door fixture device to service-action test coverage (open/close/stop). |
| tests/components/overkiz/snapshots/test_cover.ambr | Updates snapshots to include the new entity registry entry/state for the added device. |
| tests/components/overkiz/fixtures/setup/local_somfy_tahoma_v2_europe.json | Adds a representative DiscretePositionableGarageDoor device payload to reproduce/validate the issue. |
zweckj
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix cover state for Somfy Rollixo IO (DiscretePositionableGarageDoor widget) which reports
core:OpenClosedUnknownStateinstead ofcore:OpenClosedStateand does not support position control.After the cover platform migration to entity descriptions (#141330), this device falls through to the
UIClass.GARAGE_DOORdefault which looks forcore:OpenClosedStateandcore:ClosureState— neither of which exist on this device. This causes the cover to always show as "unknown" state.The fix adds a widget-specific override for
UIWidget.DISCRETE_POSITIONABLE_GARAGE_DOORthat uses the correctCORE_OPEN_CLOSED_UNKNOWNstate and omits position control (which this device doesn't support).Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: