Use config entry title for Avea light#170978
Open
pattyland wants to merge 3 commits into
Open
Conversation
home-assistant
Bot
added
bugfix
cla-signed
has-tests
integration: avea
small-pr
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Avea light entity instantiation and naming to be based on the config entry title instead of the bulb-reported name, with corresponding test adjustments.
Changes:
- Pass the config entry into
AveaLightduring setup. - Derive the entity’s
_attr_namefromentry.titleinstead oflight.name. - Simplify the Avea light test by removing the entity registry dependency and adjusting the mocked bulb name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/components/avea/test_light.py | Updates test fixtures/mocks to align with entity naming changes and removes entity registry usage. |
| homeassistant/components/avea/light.py | Changes AveaLight construction and sets the entity name from the config entry title. |
| """Initialize an AveaLight.""" | ||
| self._light = light | ||
| self._attr_name = light.name | ||
| self._attr_name = entry.title |
Contributor
Author
There was a problem hiding this comment.
I’m keeping this PR limited to the regression fix for entities being created from the library default name "Unknown". Moving Avea to device/entity naming with device_info would be a broader metadata change and is better handled separately once we have the right device identifiers.
| state = hass.states.get("light.bedroom") | ||
| assert state is not None | ||
| assert state.state == STATE_OFF | ||
| assert state.attributes[ATTR_FRIENDLY_NAME] == "Bedroom" |
| """Initialize an AveaLight.""" | ||
| self._light = light | ||
| self._attr_name = light.name | ||
| self._attr_name = entry_title |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Use the config entry title for the Avea light entity name instead of the initial
avea.Bulb.namevalue.The Avea library may still expose the default name
Unknownwhen the entity is created, even though the config flow already validated the device and created the config entry with the correct title. This prevents newly configured bulbs from being added aslight.unknownafter discovery/config flow setup.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: