Apply web search citation stripping for GPT-5.x models in OpenAI conversation#170956
Open
frenck wants to merge 1 commit into
Open
Apply web search citation stripping for GPT-5.x models in OpenAI conversation#170956frenck wants to merge 1 commit into
frenck wants to merge 1 commit into
Conversation
Contributor
|
Hey there @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes OpenAI Conversation web search responses incorrectly including Markdown inline citations for GPT‑5.x models when inline_citations is disabled, by applying the regex citation-stripping fallback to all non‑o‑series models.
Changes:
- Change the citation-stripping guard from “not a reasoning model” to “not an o‑series model” so GPT‑5.x gets the regex fallback.
- Add a regression test ensuring citations are stripped for GPT‑5 models when
web_searchis enabled andinline_citationsis disabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/openai_conversation/entity.py |
Applies citation stripping for web search to all non‑o‑series models (including GPT‑5.x). |
tests/components/openai_conversation/test_conversation.py |
Adds test coverage to validate citation stripping behavior for GPT‑5 models. |
joostlek
approved these changes
May 17, 2026
Contributor
|
Let me check if we can do this with a better prompt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When using GPT-5.x models with
web_searchenabled andinline_citationsdisabled, citations like([legaseriea.it](https://...))were still included in responses.The regex-based citation stripping was guarded by
"reasoning" not in model_args, which excluded all reasoning models. However, only o-series models (o1, o3, etc.) natively respect the prompt instruction to omit citations. GPT-5.x models do not, so they need the regex fallback.This changes the guard to
not model_args["model"].startswith("o")so that citation stripping is applied to all non-o-series models, including GPT-5.x.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: