Refactor: use shared Dialog for plan upgrade modal#3887
Open
jishnundth wants to merge 1 commit into
Open
Conversation
|
@jishnundth is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
gregfurman
requested changes
May 12, 2026
| </div> | ||
| </div> | ||
| <UpgradeModal /> | ||
| <Dialog open={showUpgradeModal} onOpenChange={setShowUpgradeModal}> |
Collaborator
There was a problem hiding this comment.
Thanks for the refactor here! Any chance you can post a screenshot of a before and after for these changes? I'd like to see how the UI changes now that we're using these internal components.
Contributor
Author
There was a problem hiding this comment.
It's the same only, the popup looks little more wider now. This is not visible in the OSS version, you've to override some variables to see managed compute on the sidebar, where this is located.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A refactor to use the common Dialog utility on plan upgrade modal.
Type of change