-
Notifications
You must be signed in to change notification settings - Fork 4.7k
grpclog: add GRPC_GO_COMPONENT_LOG_LEVEL for controling component logs #8885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
110y
wants to merge
11
commits into
grpc:master
Choose a base branch
from
110y:grpclog-component-log-severity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ef6044e
grpclog: add GRPC_GO_COMPONENT_LOG_LEVEL for controling component logs
110y 324a394
grpclog: wrap long comment lines in grpclog.go
110y c0d5868
grpclog: rename parseComponentLogLevel to parseComponentLogLevels
110y 5eda131
grpclog: add mutex to protect component cache from concurrent access
110y 1b7e50f
grpclog: remove unused parameter names in noopDepth
110y 76662e9
grpclog: move logging documentation from README to package doc comment
110y f566320
grpclog: move component log severity types and parsing to grpclog.go
110y d723006
grpclog: skip unrecognized component log levels instead of defaulting…
110y 1058fd9
grpclog: move component depth functions from loggerv2.go to component.go
110y 619a19e
grpclog: precompute component log prefix to avoid repeated string con…
110y 5492a39
Merge branch 'master' into grpclog-component-log-severity
110y File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need these function pointers? Can't we instead store the severityLevel for this component, and handle it directly in each of its methods?
As an improvement, we could even store the computed prefix in the
componentDatastruct. I'm talking about[" + string(c.name) + "]and not have to compute that for every log message.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@easwars
The reason why I use function pointers is to avoid checking severity every time a log function is called, by replacing loggers with the
noopDepthfunction according to their levels.I also think it's OK to handle it directly in each methods.
What do you think about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime, I updated the prefix computation logic: 619a19e