Add ctx in SpanDecorator option#47
Open
mmoustai wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
|
@rnburn could this be merged? |
fho
reviewed
Sep 23, 2019
| } | ||
| if otgrpcOpts.decorator != nil { | ||
| otgrpcOpts.decorator(clientSpan, method, nil, nil, err) | ||
| otgrpcOpts.decorator(context.Background(), clientSpan, method, nil, nil, err) |
There was a problem hiding this comment.
pass ctx also to the streaming interceptors:
Suggested change
| otgrpcOpts.decorator(context.Background(), clientSpan, method, nil, nil, err) | |
| otgrpcOpts.decorator(cs.Context(), clientSpan, method, nil, nil, err) |
fho
reviewed
Sep 23, 2019
| } | ||
| if otgrpcOpts.decorator != nil { | ||
| otgrpcOpts.decorator(serverSpan, info.FullMethod, nil, nil, err) | ||
| otgrpcOpts.decorator(context.Background(), serverSpan, info.FullMethod, nil, nil, err) |
There was a problem hiding this comment.
Suggested change
| otgrpcOpts.decorator(context.Background(), serverSpan, info.FullMethod, nil, nil, err) | |
| otgrpcOpts.decorator(ss.Context(), serverSpan, info.FullMethod, nil, nil, err) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to add specific tag from contextKey set in the context on an other middleware before this one.
I wasn't able to access it without adding the context in the decorator.