Skip to content

Deprecate gzip cli flag #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
stefanb wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Deprecate gzip cli flag #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func init() {
flagSet.BoolVar(&flALTS, "alts", false, "use ALTS (default: false, INSECURE plaintext transport)")
flagSet.BoolVar(&flVerbose, "v", false, "verbose logs")
flagSet.BoolVar(&flVersion, "version", false, "show probe version and exit")
flagSet.BoolVar(&flGZIP, "gzip", false, "use GZIPCompressor for requests and GZIPDecompressor for response (default: false)")
flagSet.BoolVar(&flGZIP, "gzip", false, "deprecated, gzip compression is automatically used when supported by the server")
flagSet.BoolVar(&flSPIFFE, "spiffe", false, "use SPIFFE to obtain mTLS credentials")

err := flagSet.Parse(os.Args[1:])
Expand Down Expand Up @@ -298,11 +298,11 @@ func main() {
opts = append(opts, grpc.WithInsecure())
}

// Note: GZIP compression is now handled automatically by gRPC when available
// The deprecated WithCompressor/WithDecompressor options are no longer needed
// The -gzip flag is kept for backward compatibility but has no effect
if flGZIP {
opts = append(opts,
grpc.WithCompressor(grpc.NewGZIPCompressor()),
grpc.WithDecompressor(grpc.NewGZIPDecompressor()),
)
log.Printf("warning: the -gzip flag is deprecated and no longer has any effect; gRPC compression is negotiated automatically")
}

if flVerbose {
Expand Down
Loading