Skip to content

chore: Update dependencies and do a small refactor#242

Closed
erazemk wants to merge 2 commits into
grpc-ecosystem:masterfrom
erazemk:master
Closed

chore: Update dependencies and do a small refactor#242
erazemk wants to merge 2 commits into
grpc-ecosystem:masterfrom
erazemk:master

Conversation

@erazemk
Copy link
Copy Markdown
Contributor

@erazemk erazemk commented Mar 8, 2025

This commit updates all the Go dependencies to their latest versions, updates workflow files a bit and does a small refactor, such as fixing typos and following best practices.

grpc.DialContext still needs to be updated, but I don't have enough experience with it or with this tool to be confident that I properly used it (due to the changes in the name resolver or the state changes).

@erazemk
Copy link
Copy Markdown
Contributor Author

erazemk commented Mar 8, 2025

Regarding the CLA, I'm waiting for a response from my employer on which version I should sign.
Employer signed the CLA.

@ahmetb
Copy link
Copy Markdown
Collaborator

ahmetb commented Jul 8, 2025

Sorry I couldn't get to this timely, you might wanna rebase go.{mod,sum} from HEAD as they're auto-merged from dependabot bumps now.

@erazemk
Copy link
Copy Markdown
Contributor Author

erazemk commented Aug 13, 2025

Sure @ahmetb, updated the code, so you can take a look again.

@ahmetb
Copy link
Copy Markdown
Collaborator

ahmetb commented Oct 8, 2025

Sorry this got out of sync again. :(

@erazemk
Copy link
Copy Markdown
Contributor Author

erazemk commented Oct 8, 2025

Our company switched away from grpc-health-probe, so I'm not sure it's worth me keeping this PR up to date with any changes. I guess if you review the PR and approve it (since there will not be any functional changes), then I can resolve the conflicts and immediately merge it. Otherwise it's probably easier if I just close it.

stefanb added a commit that referenced this pull request Jan 1, 2026
Cherry-picked meaningful doc updates from #242 by @erazemk

Co-Authored-By: Erazem Kokot <mail@erazemk.com>
@stefanb stefanb mentioned this pull request Jan 1, 2026
@ahmetb ahmetb closed this Jan 2, 2026
stefanb pushed a commit that referenced this pull request Jan 6, 2026
@stefanb
Copy link
Copy Markdown
Collaborator

stefanb commented Jan 7, 2026

@erazemk, this huge PR with too many unrelated / formatting changes was closed, but the meaningful changes were already included in merged

The remaining Go changes were cherry 🍒 picked for review / discussion into:

Thanks / Hvala!

@erazemk
Copy link
Copy Markdown
Contributor Author

erazemk commented Jan 12, 2026

Hi @stefanb, thanks for doing what's necessary to get these changes including, and for me giving attribution in your PRs, I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants