feat: add grpc_code label to grpc_server_handling_seconds metric#709
Draft
miparnisari wants to merge 1 commit into
Draft
feat: add grpc_code label to grpc_server_handling_seconds metric#709miparnisari wants to merge 1 commit into
grpc_code label to grpc_server_handling_seconds metric#709miparnisari wants to merge 1 commit into
Conversation
Collaborator
|
Hi, I can see this PR is left as a draft, do you intend to open an issue to discuss the addition of these metrics? I would prefer discussing additions in an issue before reviewing any implementation. |
Author
|
Hey @johanbrandhorst, we can discuss in the issue that already exists? #606 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Address #606
Mostly copied over from jon-whit/go-grpc-prometheus@b8b0828
Verification
Unit tests pass