Update payload_interceptors.go#170
Conversation
Update incorrect logging message in `PayloadUnaryServerInterceptor` from: `"server response payload logged as grpc.request.content field"` to `"server response payload logged as grpc.response.content field"`
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
- Coverage 73.47% 72.79% -0.68%
==========================================
Files 36 36
Lines 1327 1327
==========================================
- Hits 975 966 -9
- Misses 303 311 +8
- Partials 49 50 +1
Continue to review full report at Codecov.
|
domgreen
left a comment
There was a problem hiding this comment.
This change is good, but could you make the same change in logging/zap/payload_interceptors.go.
Update incorrect logging message in
PayloadUnaryServerInterceptorfrom:"server response payload logged as grpc.request.content field"to
"server response payload logged as grpc.response.content field"