Skip to content

Properly updating ctxlogrus package to reflect deprecated state#169

Open
calebice wants to merge 1 commit into
grpc-ecosystem:mainfrom
calebice:ctxlogrus_readme
Open

Properly updating ctxlogrus package to reflect deprecated state#169
calebice wants to merge 1 commit into
grpc-ecosystem:mainfrom
calebice:ctxlogrus_readme

Conversation

@calebice
Copy link
Copy Markdown

This pr simply updates the state of the README for the ctxlogrus package to reflect that the path
"github.com/grpc-ecosystem/go-grpc-middleware/tags/logrus" is now deprecated. Pure documentation update.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 27, 2018

Codecov Report

Merging #169 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   73.47%   73.17%   -0.31%     
==========================================
  Files          36       36              
  Lines        1327     1327              
==========================================
- Hits          975      971       -4     
- Misses        303      307       +4     
  Partials       49       49
Impacted Files Coverage Δ
retry/retry.go 76.11% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498ae20...7868385. Read the comment docs.

@calebice
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants