Zap custom jsonpb to allow optional gogo JSONPb serialization#149
Open
antoniomo wants to merge 4 commits into
Open
Zap custom jsonpb to allow optional gogo JSONPb serialization#149antoniomo wants to merge 4 commits into
antoniomo wants to merge 4 commits into
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 73.09% 73.09%
=======================================
Files 36 36
Lines 1349 1349
=======================================
Hits 986 986
Misses 314 314
Partials 49 49
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a POC, just to ask if anyone would be interested on it.
Basically it allows me to do:
On my service, so then I can get proper payload logging with gogo types, such as *time.Time when using
gogoproto.stdtime = true. In other words, it avoids this bug: gogo/protobuf#212Since this is
go-grpc-middleware, I guess as much compatibility withgogoas possible is desirable?Let me know if this is interesting and if so, what should I change to make it acceptable to merge (maybe the same for Logrus logger, which would be trivial? Perhaps not import the
runtime.JSONPbMarshaler fromgrpc-gatewayto avoid that extra dependency, but have our own version?).Thanks!