Skip to content

add limiter and gonify to third party#46

Merged
ReneWerner87 merged 4 commits into
gofiber:mainfrom
RajaSunrise:main
May 19, 2025
Merged

add limiter and gonify to third party#46
ReneWerner87 merged 4 commits into
gofiber:mainfrom
RajaSunrise:main

Conversation

@RajaSunrise
Copy link
Copy Markdown
Contributor

@RajaSunrise RajaSunrise commented May 16, 2025

  • gonify for middleware fiber to minify html, css , js, json, xml and SVG
  • limiter for middleware fiber to limiter with redis and three algorithm fixed-windows, sliding-window and token-bucket

Summary by CodeRabbit

  • Documentation
    • Updated the README to include new third-party middleware options for rate limiting and content minification, supporting multiple algorithms and various file types.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2025

Walkthrough

The README.md file was updated to add two new third-party Fiber middlewares: a Redis-based rate limiter supporting multiple algorithms and a minifier middleware supporting various web formats. No other changes were made to the documentation or codebase.

Changes

File(s) Change Summary
README.md Added two new third-party Fiber middlewares: rate limiter and minifier

Possibly related PRs

  • Update README.md #40: Both PRs modify the README.md file by adding or updating entries in the "Third Party" middleware section, making their changes related.

Suggested reviewers

  • gaby

Poem

A README refreshed, a list anew,
With limiters and minifiers, shiny and true!
More algorithms, more files to trim,
Fiber’s middleware list is looking quite prim.
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ef2f1b and 0074616.

📒 Files selected for processing (1)
  • README.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • README.md
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch main
  • Post Copyable Unit Tests in Comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
README.md (2)

98-98: Fix grammar and casing in the limiter entry
The description should use the plural “algorithms” (countable), capitalize “Redis” and “Fiber”, and improve clarity.

Apply this diff:

- - [narmadaweb/limiter](https://github.com/narmadaweb/limiter) - Limiter using redis and three algorithm like fixed-window, sliding-window and token-bucket for fiber.
+ - [narmadaweb/limiter](https://github.com/narmadaweb/limiter) - A rate-limiting middleware using Redis and supporting three algorithms: fixed-window, sliding-window, and token-bucket for Fiber.
🧰 Tools
🪛 LanguageTool

[grammar] ~98-~98: Possible agreement error. The noun ‘algorithm’ seems to be countable.
Context: ...imiter) - Limiter using redis and three algorithm like fixed-window, sliding-window and t...

(CD_NN)


106-106: Improve consistency and casing in the gonify entry
Use “minifying” or “minification” consistently, capitalize JSON, and add an article for readability.

Apply this diff:

- - [narmadaweb/gonify](https://github.com/narmadaweb/gonify) - Fiber Minifying middleware for HTML5, CSS3, JavaScript, Json, XML and SVG.
+ - [narmadaweb/gonify](https://github.com/narmadaweb/gonify) - A minifying middleware for Fiber that supports HTML5, CSS3, JavaScript, JSON, XML, and SVG.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4829fc1 and 6854fc5.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md

[grammar] ~98-~98: Possible agreement error. The noun ‘algorithm’ seems to be countable.
Context: ...imiter) - Limiter using redis and three algorithm like fixed-window, sliding-window and t...

(CD_NN)

Comment thread README.md Outdated
Comment thread README.md Outdated
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
README.md (2)

121-121: Grammar: pluralize “algorithm” and refine phrasing.

The noun “algorithm” should be plural (“algorithms”), and the entry can be made clearer. For example:

- - [narmadaweb/limiter](https://github.com/narmadaweb/limiter) - Limiter using redis and three algorithm like fixed-window, sliding-window and token-bucket for fiber.
+ - [narmadaweb/limiter](https://github.com/narmadaweb/limiter) - Redis-based rate limiter supporting fixed-window, sliding-window, and token-bucket algorithms.
🧰 Tools
🪛 LanguageTool

[grammar] ~121-~121: Possible agreement error. The noun ‘algorithm’ seems to be countable.
Context: ...imiter) - Limiter using redis and three algorithm like fixed-window, sliding-window and t...

(CD_NN)


122-122: Typo: incorrect casing for “JSON”.

The acronym “JSON” should be uppercase to match other entries, and adding an Oxford comma improves consistency:

- - [narmadaweb/gonify](https://github.com/narmadaweb/gonify) - Fiber Minifying middleware for HTML5, CSS3, JavaScript, Json, XML and SVG.
+ - [narmadaweb/gonify](https://github.com/narmadaweb/gonify) - Fiber Minifying middleware for HTML5, CSS3, JavaScript, JSON, XML, and SVG.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6854fc5 and 22283da.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md

[grammar] ~121-~121: Possible agreement error. The noun ‘algorithm’ seems to be countable.
Context: ...imiter) - Limiter using redis and three algorithm like fixed-window, sliding-window and t...

(CD_NN)

Comment thread README.md
Comment thread README.md Outdated
Copy link
Copy Markdown
Member

@renanbastos93 renanbastos93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!
I left two suggestions — let me know what you think.

Co-authored-by: Renan Bastos <renanbastos.tec@gmail.com>
@gaby
Copy link
Copy Markdown
Member

gaby commented May 19, 2025

@RajaSunrise There's a issue with the linter, a space is missing

@RajaSunrise
Copy link
Copy Markdown
Contributor Author

@gaby 👍

Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor Author

@RajaSunrise RajaSunrise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Comment thread README.md Outdated
@ReneWerner87 ReneWerner87 merged commit f268890 into gofiber:main May 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants