test(middleware/tracing): add assertions for ClientHandler statshandler tests#3812
Open
sevico wants to merge 1 commit into
Open
test(middleware/tracing): add assertions for ClientHandler statshandler tests#3812sevico wants to merge 1 commit into
sevico wants to merge 1 commit into
Conversation
…er tests TestClient_HandleConn and TestClient_HandleRPC used `_ *testing.T`, discarding the test parameter entirely, which made it impossible to add any assertions. The tests only exercised code paths without verifying behavior. Refactor TestClient_HandleRPC into subtests covering all branches: - non-OutHeader stats are ignored - missing peer context causes early return - invalid span context skips attribute setting - valid span with peer correctly sets net.peer.ip and net.peer.port Replace the unused mockSpan with a recordingSpan that captures SetAttributes calls, enabling actual verification of the tracing instrumentation logic.
dosubot
Bot
added
the
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestClient_HandleConnandTestClient_HandleRPCused_ *testing.T, discarding the test parameter, making it impossible to assert any behavior.TestClient_HandleRPCinto subtests covering all branches: non-OutHeader ignored, missing peer early return, invalid span context skipped, and valid span with peer correctly settingnet.peer.ipandnet.peer.portattributes.mockSpanwith arecordingSpanthat capturesSetAttributescalls for actual verification.Test plan
go test ./middleware/tracing/ -v -run "TestClient"passes