test(middleware/selector): add assertions for TestMatch and TestMatchClient#3811
Open
sevico wants to merge 1 commit into
Open
test(middleware/selector): add assertions for TestMatch and TestMatchClient#3811sevico wants to merge 1 commit into
sevico wants to merge 1 commit into
Conversation
…Client
The existing TestMatch and TestMatchClient had test cases but lacked
assertions to verify whether the middleware was actually applied based
on the matching rules (Prefix, Regex, Path). This made the tests
unable to catch regressions in the selector matching logic.
Add a middlewareApplied flag and expected want field to each test case,
verifying that:
- Prefix("/hello/") matches operations starting with /hello/
- Regex(`/test/[0-9]+`) matches numeric test paths
- Path("/example/kratos") matches exact paths
- Non-matching operations are correctly skipped
dosubot
Bot
added
the
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestMatchandTestMatchClienthad test cases but lacked assertions — they only called the handler without verifying whether the middleware was actually applied based on matching rules.middlewareAppliedflag and expectedwantfield to each test case, verifying thatPrefix,Regex, andPathmatching rules work correctly for both server and client selectors.// TODO: Add test cases.comments.Test plan
go test ./middleware/selector/ -v -run "TestMatch"passes