Skip to content

fix(transport): check if body is empty before get Content-Type decoder #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MikasaAkerman wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(transport): check if body is empty before get Content-Type decoder #3654

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d5c190
fix(transport): check if body is empty before get Content-Type decoder
Apr 27, 2025
2e3cb0c
Merge branch 'main' into fix_empty_req_body
MikasaAkerman Jul 25, 2025
e400048
Update codec.go
MikasaAkerman Jul 25, 2025
c43974d
Merge branch 'go-kratos:main' into fix_empty_req_body
MikasaAkerman Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions transport/http/codec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ func DefaultRequestQuery(r *http.Request, v any) error {

// DefaultRequestDecoder decodes the request body to object.
func DefaultRequestDecoder(r *http.Request, v any) error {
codec, ok := CodecForRequest(r, "Content-Type")
if !ok {
return errors.BadRequest("CODEC", fmt.Sprintf("unregister Content-Type: %s", r.Header.Get("Content-Type")))
}
data, err := io.ReadAll(r.Body)
Copy link
Copy Markdown
Member

@tonybase tonybase Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/go-kratos/kratos/blob/0d5c1900601cc9a39fc0937acc7496df03d89726/transport/http/codec.go#L67C2-L69C3

need to check the error.

Copy link
Copy Markdown
Author

@MikasaAkerman MikasaAkerman Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


// reset body.
Expand All @@ -74,6 +70,12 @@ func DefaultRequestDecoder(r *http.Request, v any) error {
if len(data) == 0 {
return nil
}

codec, ok := CodecForRequest(r, "Content-Type")
if !ok {
return errors.BadRequest("CODEC", fmt.Sprintf("unregister Content-Type: %s", r.Header.Get("Content-Type")))
}

if err = codec.Unmarshal(data, v); err != nil {
return errors.BadRequest("CODEC", fmt.Sprintf("body unmarshal %s", err.Error()))
}
Expand Down