refactor(clippy): collapse nested if blocks in detect.rs#628
Merged
jamesadevine merged 1 commit intoMay 19, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What clippy found
Three consecutive
collapsible_iferrors insrc/detect.rs(lines 64–73):Four nested
ifblocks were checkingis_file(), then the extension, then the extension value, then the pipeline detection result.How it was fixed
Lint:
clippy::collapsible_ifFix: Collapsed all three nested
ifs into a singleif letchain using Rust 2024 edition's stabilisedif letchainsFile touched:
src/detect.rsVerification
cargo build --all-targets✅cargo test✅ (all tests pass)cargo clippy --all-targets --all-features --workspace -- -D warnings✅ (no warnings fordetect.rs)Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
dev.azure.comSee Network Configuration for more information.