Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate integrations reference from catalog #2563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
generate integrations reference from catalog #2563
Changes from 26 commits
848cb962a72b53df40ef873602cac621732b4bd56f7caace801be38f70afa5c1c5af18b64cc3bc351766e9c4bc47d1a401dd32eb1d9bda8af11bca94dab389be4b7a628e68d62b27eed295dcb6826fbf577c732734fff7c60fc926e27556847b39826ecc914c1f078b538fd218141018c85a00bFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Updated the
typer.echo()call to usenl=False, which prevents adding an extra newline sincerender_integrations_table()already returns a string with a trailing newline. This keeps the CLI output clean and consistent.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Renamed
_escape_url_for_markdown_link()toescape_url_for_markdown_link()(now public) incatalog_docs.py, and updated the import incommunity_catalog_docs.pyto use the public name. This removes the "private API" coupling concern.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Updated the error message to describe the actual requirement instead of referencing the CLI flag: "Community catalog not found at {path}. Ensure the repository checkout includes the extensions/ directory." This is now accurate for both CLI and programmatic usage.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.