Skip to content

fix(utils): Make execa usage consistent in git utils #12028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slorber merged 5 commits into from
May 21, 2026
+18 −18
Merged

fix(utils): Make execa usage consistent in git utils #12028

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e01de9
Make execa usage consistent in git utils
zpao May 15, 2026
6287dc8
Apply suggestions from code review
zpao May 15, 2026
8533170
Merge branch 'main' into execagit
slorber May 21, 2026
28736c1
trigger CI with former VCS 'git-ad-hoc'
slorber May 21, 2026
c314d5a
Revert "trigger CI with former VCS 'git-ad-hoc'"
slorber May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions packages/docusaurus-utils/src/vcs/gitUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,25 +147,25 @@ export async function getFileCommitDate(
// See why: https://github.com/facebook/docusaurus/pull/10022
const resultFormat = includeAuthor ? 'RESULT:%ct,%an' : 'RESULT:%ct';

const args = [
`--format=${resultFormat}`,
'--max-count=1',
age === 'oldest' ? '--follow --diff-filter=A' : undefined,
]
.filter(Boolean)
.join(' ');

// Do not include GPG signature in the log output
// See https://github.com/facebook/docusaurus/pull/10022
const command = `git -c log.showSignature=false log ${args} -- "${path.basename(
file,
)}"`;

const result = (await GitCommandQueue.add(() => {
return execa(command, {
cwd: path.dirname(file),
shell: true,
});
return execa(
'git',
[
// Do not include GPG signature in the log output
// See https://github.com/facebook/docusaurus/pull/10022
'-c',
'log.showSignature=false',
'log',
`--format=${resultFormat}`,
'--max-count=1',
...(age === 'oldest' ? ['--follow', '--diff-filter=A'] : []),
Comment thread
zpao marked this conversation as resolved.
'--',
path.basename(file),
],
{
cwd: path.dirname(file),
},
);
}))!;

if (result.exitCode !== 0) {
Expand Down
Loading