Fix devcontainer#12026
Conversation
|
Hi @JanOlencki! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Pre-flight checklist
Motivation
The devcontainer doesn't work properly. It halts on a prompt asking for a confirmation. Also the version of Node.JS is a bit out-of-date.
The former error looks as following:
The latter error is:
You can reproduce it locally by executing
devcontainer up --workspace-folder .or in a browser by creating Codespace.Test Plan
I haven't found an automatic test of the devcontainer. I think manual testing is sufficient here. I have tested it both locally and in Codespace.
Test links
GitHub Codespaces docs
Related issues/PRs