Skip to content

Fix devcontainer#12026

Open
JanOlencki wants to merge 2 commits into
facebook:mainfrom
JanOlencki:fix-devcontainer
Open

Fix devcontainer#12026
JanOlencki wants to merge 2 commits into
facebook:mainfrom
JanOlencki:fix-devcontainer

Conversation

@JanOlencki
Copy link
Copy Markdown

@JanOlencki JanOlencki commented May 15, 2026

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The devcontainer doesn't work properly. It halts on a prompt asking for a confirmation. Also the version of Node.JS is a bit out-of-date.

The former error looks as following:

! Corepack is about to download https://registry.yarnpkg.com/yarn/-/yarn-1.22.22.tgz
? Do you want to continue? [Y/n]

The latter error is:

error create-docusaurus@3.10.1: The engine "node" is incompatible with this module. Expected version ">=24.14". Got "22.22.2"

You can reproduce it locally by executing devcontainer up --workspace-folder . or in a browser by creating Codespace.

Test Plan

I haven't found an automatic test of the devcontainer. I think manual testing is sufficient here. I have tested it both locally and in Codespace.

Test links

GitHub Codespaces docs

Related issues/PRs

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 15, 2026

Hi @JanOlencki!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit a1cbfa2
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6a0768063906f00008fff692
😎 Deploy Preview https://deploy-preview-12026--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 15, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label May 15, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 15, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant