Skip to content

feat(scaling-dive): new-changes-batch matrix entry #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcLear merged 1 commit into from
May 15, 2026
Merged

feat(scaling-dive): new-changes-batch matrix entry #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/scaling-dive.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
strategy:
fail-fast: false
matrix:
lever: [baseline, websocket-only, nodemem]
lever: [baseline, websocket-only, nodemem, new-changes-batch]

env:
PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
Expand Down Expand Up @@ -119,6 +119,12 @@ jobs:
# No settings change; NODE_OPTIONS is set when launching below.
echo "applied via NODE_OPTIONS"
;;
new-changes-batch)
# Lever 3b: pack multi-rev fan-out into one NEW_CHANGES_BATCH emit
# per recipient. Requires the core_ref to include ether/etherpad#7768.
sed -i '/"loadTest": true,/a\ "newChangesBatch": true,' settings.json
grep newChangesBatch settings.json || { echo "newChangesBatch not present — core must include #7768"; exit 1; }
;;
*)
echo "unknown lever: ${{ matrix.lever }}" >&2
exit 1
Expand Down
Loading