Fix 1698#1720
Conversation
This fixes the trailing whitespace stripping behavior on save: - Excludes Markdown and YAML files where trailing whitespace can be semantically meaningful. - Adds description/subtext in the settings switch to clarify that it only applies to syntax-highlighted files, except Markdown and YAML. Fixes elementary#1698
|
Hi @jeremypw, I've implemented the exclusion list and updated the settings switch description to list Markdown and YAML as exclusions, matching the 'smart cut/copy' style. Btw, earlier I was planning to solve both #1698 and #1699 together, but decided to separate them to keep the PR clean. I will submit the PR for #1699 after this is reviewed. |
|
I agree those two issues should be considered in separate PRs, they are not sufficiently interdependent to deal with together. Will review this one shortly. |
|
will create separate PRs for both issues to avoid any conflicts. Thanks for the feedback, looking forward to your review! |
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
This works as expected.
The only thing I am unsure about is the wording of the label subtext. "Syntax highlighting" may not be turned on and some source languages may not have any visible highlighting yet trailing spaces are still stripped. It may be sufficient just to say "Except Plain Text, MarkDown and YAML"?
3 participants
Preferences:- Exclude Markdown and YAML from whitespace stripping
This fix the trailing whitespace stripping behavior on save:--
Fixes Stripping of trailing whitespace affects only some files; no UI indication which types #1698../