fix(coding-agent): guard undici install under Bun#4661
Merged
badlogic merged 2 commits intoMay 18, 2026
Conversation
Contributor
|
This PR was auto-closed. Only contributors approved with Maintainers review auto-closed issues daily. Issues that do not meet the quality bar in CONTRIBUTING.md will not be reopened or receive a reply. If a maintainer replies See CONTRIBUTING.md. |
Collaborator
|
cheers |
Collaborator
|
cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the v0.75.1 Bun-compiled release binary startup crash caused by statically importing
installfromundici.Bun's built-in
undicimodule exposesEnvHttpProxyAgentandsetGlobalDispatcher, but notinstall, so the binary fails during module loading with:This changes the import to a namespace import and calls
install()only when that export exists. That should preserve the Node 26 fix for #4650, #4652, and #4653, because npmundicistill exportsinstall()under Node, while avoiding the Bun startup crash where the export is absent.Fixes #4657.
Testing
npm run checkpi --version/pi --helpwork after installing through my NixOS flake