Skip to content

Allow empty string identifiers on non-flags enums in JsonStringEnumConverter and disallow non-flags comma-splitting #128285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from

Fix non-flags enum parsing for empty-name comma-separated inputs

475c55f
Select commit
Loading
Failed to load commit list.
Open

Allow empty string identifiers on non-flags enums in JsonStringEnumConverter and disallow non-flags comma-splitting #128285

Fix non-flags enum parsing for empty-name comma-separated inputs
475c55f
Select commit
Loading
Failed to load commit list.
Azure Pipelines / runtime failed May 18, 2026 in 3h 2m 49s

Build #20260518.84 had test failures

16 errors / 30 warnings

Details

Tests

  • Failed: 706 (0.03%)
  • Passed: 1,980,831 (97.88%)
  • Other: 42,135 (2.08%)
  • Total: 2,023,672

Annotations

Check failure on line 91 in .packages/microsoft.dotnet.helix.sdk/11.0.0-beta.26257.113/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages/microsoft.dotnet.helix.sdk/11.0.0-beta.26257.113/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91 

.packages/microsoft.dotnet.helix.sdk/11.0.0-beta.26257.113/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item WasmTestOnV8-CLR-ST-System.Runtime.Tests in job 06e18969-bd96-476f-b313-15a17ba0a426 has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/06e18969-bd96-476f-b313-15a17ba0a426/workitems/WasmTestOnV8-CLR-ST-System.Runtime.Tests/console

Check failure on line 91 in .packages/microsoft.dotnet.helix.sdk/11.0.0-beta.26257.113/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages/microsoft.dotnet.helix.sdk/11.0.0-beta.26257.113/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91 

.packages/microsoft.dotnet.helix.sdk/11.0.0-beta.26257.113/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item WasmTestOnFirefox-CLR-ST-System.Runtime.Tests in job c0359543-1f0f-4cad-9cd4-0266c6bcc4d6 has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/c0359543-1f0f-4cad-9cd4-0266c6bcc4d6/workitems/WasmTestOnFirefox-CLR-ST-System.Runtime.Tests/console

Check failure on line 233 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

Build log #L233 

The Operation will be canceled. The next steps may not contain expected logs.

Check failure on line 1 in System.Tests.ActivatorTests.TestingCreateInstanceFromObjectHandle

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

System.Tests.ActivatorTests.TestingCreateInstanceFromObjectHandle 

Test failed

Check failure on line 1 in System.Tests.ActivatorTests.TestingCreateInstanceFromObjectHandleFullSignature

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

System.Tests.ActivatorTests.TestingCreateInstanceFromObjectHandleFullSignature 

Test failed

Check failure on line 1 in WasmTestOnFirefox-CLR-ST-System.Runtime.Tests.WorkItemExecution

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

WasmTestOnFirefox-CLR-ST-System.Runtime.Tests.WorkItemExecution 

The Helix Work Item failed. Often this is due to a test crash. Please see the 'Artifacts' tab above for additional logs.

Check failure on line 1 in System.Tests.ActivatorTests.TestingCreateInstanceFromObjectHandle

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

System.Tests.ActivatorTests.TestingCreateInstanceFromObjectHandle 

Test failed
View more details on Azure Pipelines