-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fix: keep anchor links aligned after layout changes #2731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
apples-kksk
wants to merge
12
commits into
docsifyjs:develop
Choose a base branch
from
apples-kksk:fix-anchor-scroll-after-layout
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1110202
fix: keep anchor scroll aligned after layout changes
apples-kksk cf22daf
Address anchor scroll review feedback
apples-kksk 05439cf
fix: preserve smooth anchor scroll during resync
apples-kksk 55e2e57
test: cover delayed anchor resync timing
apples-kksk d8a7953
ci: add windows consumption diagnostics
apples-kksk 911de76
Revert "ci: add windows consumption diagnostics"
apples-kksk 5459fb7
fix: smooth delayed anchor realignment
apples-kksk d55f1be
fix: minimize delayed anchor realignment pause
apples-kksk 8246c57
Revert "fix: minimize delayed anchor realignment pause"
apples-kksk 6ebd086
fix: avoid repeated anchor scroll corrections
apples-kksk 98f2454
fix: keep anchors aligned after late image loads
apples-kksk 2e567d5
fix: preserve anchor offsets after fallback scroll
apples-kksk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import docsifyInit from '../helpers/docsify-init.js'; | ||
| import { test, expect } from './fixtures/docsify-init-fixture.js'; | ||
|
|
||
| test.describe('Anchor scrolling', () => { | ||
| test('keeps direct anchor targets aligned after images above them load', async ({ | ||
| page, | ||
| }) => { | ||
| await page.route('**/slow-anchor-image.svg', async route => { | ||
| await new Promise(resolve => setTimeout(resolve, 250)); | ||
| await route.fulfill({ | ||
| contentType: 'image/svg+xml', | ||
| body: ` | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="640" height="900"> | ||
| <rect width="640" height="900" fill="#ddd" /> | ||
| </svg> | ||
| `, | ||
| }); | ||
| }); | ||
|
|
||
| await docsifyInit({ | ||
| testURL: '/docsify-init.html#/?id=target-section', | ||
| markdown: { | ||
| homepage: ` | ||
| # Anchor Scroll | ||
|
|
||
|  | ||
|
|
||
| ## Middle Section | ||
|
|
||
| This section should not stay at the top after the image loads. | ||
|
|
||
| ## Target Section | ||
|
|
||
| This is the linked section. | ||
|
|
||
| Trailing content keeps the target scrollable. | ||
| `, | ||
| }, | ||
| routes: { | ||
| '/docsify-init.html': ` | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| </head> | ||
| <body> | ||
| <div id="app"></div> | ||
| </body> | ||
| </html> | ||
| `, | ||
| }, | ||
| style: ` | ||
| .markdown-section img { | ||
| display: block; | ||
| width: 100%; | ||
| height: auto; | ||
| } | ||
|
|
||
| .markdown-section { | ||
| padding-bottom: 1200px; | ||
| } | ||
| `, | ||
| styleURLs: ['/dist/themes/core.css'], | ||
| }); | ||
|
|
||
| await expect | ||
| .poll(async () => { | ||
| return page.locator('#target-section').evaluate(el => { | ||
| return el.getBoundingClientRect().top; | ||
| }); | ||
| }) | ||
| .toBeLessThan(80); | ||
|
apples-kksk marked this conversation as resolved.
Outdated
|
||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.