Add imagePullSecrets and extend imagePullPolicy to all chart images by Bhawanishanker22 · Pull Request #372 · debezium/debezium-platform

Bhawanishanker22 · 2026-04-24T06:59:32Z

Fixes debezium/debezium#1851

Description

Extends imagePullPolicy support and adds imagePullSecrets configuration
for all container images in the Helm chart.

Changes

values.yaml

Added top-level imagePullSecrets: [] — global pull secrets applied to all images by default
Added stage.imagePullSecrets — per-component override for the stage image
Added conductor.imagePullSecrets — per-component override for the conductor image
Added conductor.descriptors.official.imagePullPolicy — previously missing pull policy for the descriptors OCI image
Added conductor.descriptors.official.imagePullSecrets — per-component override for the descriptors image
Added server.imagePullPolicy — previously missing pull policy for Debezium Server instances
Added server.imagePullSecrets — per-component override for the Debezium Server image

conductor-deployment.yaml

Injected imagePullSecrets block into pod spec using a global → per-component fallback pattern

stage-deployment.yaml

Injected imagePullSecrets block into pod spec using the same global → per-component fallback pattern

README.md

Added documentation rows for all 8 new configuration fields

Behaviour

Per-component imagePullSecrets overrides (does not merge with) the global list — consistent with standard Kubernetes and Helm chart conventions
All new fields are optional and default to empty — fully backward compatible with existing installations
When both global and component secrets are empty, no imagePullSecrets key is rendered in the pod spec

PR Checklist

I have read the contribution guidelines and the governance document on PR expectations.
Minimal changes to code not directly related to your change (e.g. no unnecessary formatting changes or refactoring to existing code)
One feature/change per PR unless tightly coupled
Do a rebase on upstream main

…x message

…lisation

… on join tables

mfvitale · 2026-04-27T09:58:32Z

@Bhawanishanker22 thanks for the PR. I left some comments.

github-actions · 2026-04-29T18:08:44Z

Hi @Bhawanishanker22, thanks for your contribution. Please prefix the commit message(s) with the debezium/dbz#xxx GitHub issue key.

github-actions · 2026-04-29T18:17:16Z

Hi @Bhawanishanker22, thanks for your contribution. Please prefix the commit message(s) with the debezium/dbz#xxx GitHub issue key.

…Secrets, add ORAS credentials via secretKeyRef, remove unsupported imagePullPolicy from server Signed-off-by: Bhawani Shanker Sharma <bhawanishanker2005@gmail.com>

Bhawanishanker22 · 2026-04-30T02:33:54Z

@mfvitale The 2 failing tests in Run tests (ConnectionValidatorFactoryTest.shouldReturnDatabaseValidatorForOracle and PulsarConnectionValidatorTest.shouldFailValidationWithEmptyServiceHttpUrl) are failing with "Failed to start quarkus" — a Quarkus startup error in the CI environment unrelated to the changes in this PR. These tests depend on Oracle and Pulsar Testcontainers infrastructure. Could you confirm if these are pre-existing flaky tests in CI?

mfvitale · 2026-04-30T09:07:07Z

@Bhawanishanker22 could you please rebase with the latest main changes. This should solve the unrelated test failures.

github-actions · 2026-05-15T05:42:36Z

❌ Developer Certificate of Origin (DCO) check failed.

Hi @Bhawanishanker22, please sign off all commits with:

git commit -s

If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes.

github-actions · 2026-05-15T05:42:36Z

Hi @Bhawanishanker22, thanks for your contribution. Please prefix the commit message(s) with the debezium/dbz#xxx GitHub issue key.

…all chart images Signed-off-by: Bhawani Shanker Sharma <bhawanishanker2005@gmail.com>

github-actions · 2026-05-15T05:55:55Z

Hi @Bhawanishanker22, thanks for your contribution. Please prefix the commit message(s) with the debezium/dbz#xxx GitHub issue key.

github-actions · 2026-05-15T05:56:03Z

❌ Developer Certificate of Origin (DCO) check failed.

Hi @Bhawanishanker22, please sign off all commits with:

git commit -s

If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes.

…all chart images Signed-off-by: Bhawani Shanker Sharma <bhawanishanker2005@gmail.com>

github-actions · 2026-05-15T05:56:37Z

❌ Developer Certificate of Origin (DCO) check failed.

Hi @Bhawanishanker22, please sign off all commits with:

git commit -s

If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes.

github-actions · 2026-05-15T05:56:43Z

Hi @Bhawanishanker22, thanks for your contribution. Please prefix the commit message(s) with the debezium/dbz#xxx GitHub issue key.

…all chart images Signed-off-by: Bhawani Shanker Sharma <bhawanishanker2005@gmail.com>

github-actions · 2026-05-15T06:00:58Z

❌ Developer Certificate of Origin (DCO) check failed.

Hi @Bhawanishanker22, please sign off all commits with:

git commit -s

If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes.

github-actions · 2026-05-15T06:01:05Z

Hi @Bhawanishanker22, thanks for your contribution. Please prefix the commit message(s) with the debezium/dbz#xxx GitHub issue key.

github-actions · 2026-05-15T06:01:21Z

Hi @Bhawanishanker22, thanks for your contribution. Please prefix the commit message(s) with the debezium/dbz#xxx GitHub issue key.

github-actions · 2026-05-15T06:01:46Z

❌ Developer Certificate of Origin (DCO) check failed.

Hi @Bhawanishanker22, please sign off all commits with:

git commit -s

If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes.

Bhawanishanker22 · 2026-05-15T07:19:43Z

@mfvitale Hi, I've added DCO sign-off to all commits via filter-branch and the commit messages already follow the debezium/dbz#1851 format. Could you please approve the workflows so the checks can re-run? Thanks!

mfvitale · 2026-05-15T07:43:33Z

@Bhawanishanker22 I'm afraid that there is something bad with the commit history. Could you please do a clean rebase with the main? Thanks

jcechace added 30 commits April 24, 2024 15:35

Project bootstrap

98b6e4c

Initial CRUD bootstrap

170353c

Initial CRUD API endpoints

e26b621

Removed blaze persistence processor

85bd114

Fixed API base path

566f2dd

Fixed entity removal via view

163ff6f

Storing vault content as JSON instead of element collection

a69033b

Added missing @UpdatableEntityView to Pipeline

1cfa480

Pipeline and Vault CRUD operations now also send an appropriate outbo…

430a4f4

…x message

Initial draft of Environment SPI

08426e6

PipelineFlat must be updatable in order to expose setters for deseria…

1e20534

…lisation

Initial implementation of operator environment

bf25780

Ability to build multiplatform container image via maven

3857a05

Enabling db dev services only in dev profile

2b3a3f8

Added compose file

1f433ba

Always include swagger ui

57af242

Always pull conductor nightly image when running compose

65ce60f

Moved REST API compose under examples

1f06311

Full conductor example using compose + kind

f4d465b

Vaults now also include values

785a5f2

Properly setting many-to-many relatinships in order to generate pkeys…

4bf3011

… on join tables

Workaround for BP delete issue

002adc4

Fixed typo in DS configuration

afaa485

Added unique constrain on names and description field

d0cefcd

Added the description filed to pipeline views

fef40d0

Temporarily hardcoding some pipeline configuration

a983a56

Aligning with Debezium Operator 2.7.0.Beta2

9482e88

WebSocket endpoint for streamining pipeline logs

a876956

Fixed duplicit destination name in test

ef3b077

Updated operator api to 3.0.0-SNAPHSOT

d794670

Bhawanishanker22 force-pushed the fix-imagepullsecrets-1851 branch from 041a921 to 2dda383 Compare April 24, 2026 07:13

mfvitale reviewed Apr 27, 2026

View reviewed changes

Comment thread helm/templates/conductor-deployment.yaml

mfvitale reviewed Apr 27, 2026

View reviewed changes

Comment thread helm/values.yaml Outdated

mfvitale reviewed Apr 27, 2026

View reviewed changes

Comment thread helm/values.yaml

Bhawanishanker22 force-pushed the fix-imagepullsecrets-1851 branch from 9e5c5d4 to a07a2f7 Compare April 29, 2026 18:17

debezium/dbz#1851 Address review comments: use coalesce for imagePull…

e336c99

…Secrets, add ORAS credentials via secretKeyRef, remove unsupported imagePullPolicy from server Signed-off-by: Bhawani Shanker Sharma <bhawanishanker2005@gmail.com>

Bhawanishanker22 force-pushed the fix-imagepullsecrets-1851 branch from a07a2f7 to e336c99 Compare April 29, 2026 18:17

Bhawanishanker22 added 2 commits May 15, 2026 11:15

debezium/dbz#1851 Add imagePullSecrets and extend imagePullPolicy to …

7a780e9

…all chart images Signed-off-by: Bhawani Shanker Sharma <bhawanishanker2005@gmail.com>

debezium/dbz#1851 Add imagePullSecrets and extend imagePullPolicy to …

1c93f70

…all chart images Signed-off-by: Bhawani Shanker Sharma <bhawanishanker2005@gmail.com>

Bhawanishanker22 force-pushed the fix-imagepullsecrets-1851 branch from a3ce6e3 to 1c93f70 Compare May 15, 2026 05:53

debezium/dbz#1851 Add imagePullSecrets and extend imagePullPolicy to …

78beff6

…all chart images Signed-off-by: Bhawani Shanker Sharma <bhawanishanker2005@gmail.com>

debezium/dbz#1851 Add imagePullSecrets and extend imagePullPolicy to …

e4805cb

…all chart images Signed-off-by: Bhawani Shanker Sharma <bhawanishanker2005@gmail.com>

Bhawanishanker22 force-pushed the fix-imagepullsecrets-1851 branch from 5db9242 to e4805cb Compare May 15, 2026 05:59

Uh oh!

Conversation

Bhawanishanker22 commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Behaviour

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mfvitale commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

Bhawanishanker22 commented Apr 30, 2026

Uh oh!

mfvitale commented Apr 30, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

Bhawanishanker22 commented May 15, 2026

Uh oh!

mfvitale commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Bhawanishanker22 commented Apr 24, 2026 •

edited

Loading