Skip to content

debezium/dbz#1097 Add support for connection validator for Milvus#310

Open
kartikangiras wants to merge 5 commits into
debezium:mainfrom
kartikangiras:dbz#1097
Open

debezium/dbz#1097 Add support for connection validator for Milvus#310
kartikangiras wants to merge 5 commits into
debezium:mainfrom
kartikangiras:dbz#1097

Conversation

@kartikangiras
Copy link
Copy Markdown

@kartikangiras kartikangiras commented Mar 21, 2026

Description:

  • Implement ConnectionValidator for Milvus
  • Add MILVUS type to ConnectionEntity enum and JSON schema
  • Support token and username/password authentication
  • Include unit and integration tests with Testcontainers
  • Configure connection timeout (60s default)

fixes debezium/dbz#1097
DBZ-9440

@kartikangiras
Copy link
Copy Markdown
Author

kartikangiras commented Mar 21, 2026

@kmos @Naros PTAL into this PR Thanks.

@kmos kmos requested review from Naros, jpechane and kmos March 23, 2026 08:49
mfvitale
mfvitale reviewed Mar 23, 2026
View reviewed changes
Comment thread debezium-platform-conductor/pom.xml Outdated
@mfvitale
Copy link
Copy Markdown
Member

mfvitale commented Mar 23, 2026

Hi @kartikangiras Overall it LGMT. I just left a minor comment and started the CI

Naros
Naros approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mfvitale
Copy link
Copy Markdown
Member

mfvitale commented Mar 26, 2026

@kartikangiras failure seems related. Could you please take a look?

@kartikangiras
debezium/dbz#1097 Add support for connection validator for Milvus
f97bcd4 
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
@kartikangiras
debezium/dbz#1097 Add Milvus version property and enhance connection …
a69ed63 
…validation tests

Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
@kartikangiras
debezium/dbz#1097 Add test dependencies for Testcontainers and Quarku…
0e6b27c 
…s test common

Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
@kartikangiras
Copy link
Copy Markdown
Author

kartikangiras commented Mar 26, 2026

@mfvitale I have added certain test dependencies due to which CI check was failing.

@kartikangiras kartikangiras requested a review from mfvitale March 26, 2026 14:19
@kartikangiras
Copy link
Copy Markdown
Author

kartikangiras commented Mar 26, 2026

@mfvitale I have placed the MilvusTestResource under the test directory now.

@kartikangiras
debezium/dbz#1097 Refactor MilvusTestResource location
72eb284 
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
kmos
kmos reviewed Mar 26, 2026
View reviewed changes
Comment thread .../java/io/debezium/platform/environment/connection/destination/MilvusConnectionValidator.java Outdated
Comment thread .../java/io/debezium/platform/environment/connection/destination/MilvusConnectionValidator.java Outdated
Naros
Naros reviewed Mar 27, 2026
View reviewed changes
Comment thread .../java/io/debezium/platform/environment/connection/destination/MilvusConnectionValidator.java
Comment on lines +174 to +175
if (errorMessage.contains("timeout") || errorMessage.contains("TimeoutException") ||
errorMessage.contains("deadline")) {
Copy link
Copy Markdown
Member

@Naros Naros Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmos @mfvitale, given that Milvus' error strategy is evolving and necessitates these string checks, should we consider encapsulating this in a dedicated Milvus package & handler that could return a Debezium-specific exception, so places like this can be much cleaner?

Copy link
Copy Markdown
Member

@mfvitale mfvitale Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, in general, that we should improve sink error management. So this could be something we could approach during DS rewrite?

Copy link
Copy Markdown
Member

@kmos kmos Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I totally agree

@mfvitale
Copy link
Copy Markdown
Member

mfvitale commented Mar 27, 2026

@kartikangiras Could you take a look to test failures?

@kartikangiras
Copy link
Copy Markdown
Author

kartikangiras commented Mar 27, 2026

@kartikangiras Could you take a look to test failures?

Yeah sure, I'm on it.

@kartikangiras
Copy link
Copy Markdown
Author

kartikangiras commented Apr 2, 2026 •
edited
Loading

@mfvitale I have resolved all the comments and made relevant changes Thanks.

@mfvitale
Copy link
Copy Markdown
Member

mfvitale commented Apr 7, 2026

@kartikangiras test failure are related.

@kartikangiras
Copy link
Copy Markdown
Author

kartikangiras commented Apr 19, 2026

@mfvitale I have made some changes, locally the tests pass succesfully.

@kartikangiras
debezium/dbz#1097 Refactor connection validation error handling
1d96657 
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
@mfvitale
Copy link
Copy Markdown
Member

mfvitale commented Apr 21, 2026

@kartikangiras Could you please have a look to checkstyle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Naros Naros Naros approved these changes

@jpechane jpechane jpechane approved these changes

@kmos kmos kmos approved these changes

@mfvitale mfvitale Awaiting requested review from mfvitale

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add connection validator for Milvus [DBZ-9440]

5 participants

@kartikangiras @mfvitale @jpechane @Naros @kmos