debezium/dbz#1879 Add SMT EnforceRecordSize#284
Open
twthorn wants to merge 1 commit into
Open
Conversation
Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com>
Naros
reviewed
May 18, 2026
Member
There was a problem hiding this comment.
I wonder whether there should be more surgical algorithms, such as largest-first or greedy. I also wonder if the SMT should explicitly prefer a list of field names.
Let's say we have an event with 10 fields, 9 of which are 10 bytes each, and one is 5000 bytes, for a total of 5090 bytes. If we assume that the event's size exceeds a 2000-byte threshold, all 9 smaller fields are dropped to 6 bytes, which I think risks making the entire event potentially irrelevant.
Let's wait and see how Jiri views the PR behavior; maybe he sees something I am glossing over.
Contributor
|
@twthorn Hi, thanks for the PR! Two comments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debezium/dbz#1879
Add an SMT for enforcing record size with the current strategy of proportional column truncation.
We still need to performance test this. Some optimizations with caching may be needed.
We may support other strategies in the future, one such is payload offloading debezium/dbz#1949