debezium/dbz#188 Stop using KafkaConnectUtil#283
Draft
vjuranek wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Vojtech Juranek <vojtech.juranek@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates Vitess connector unit tests to stop using the removed/undesired KafkaConnectUtil helper by switching to the newer Debezium offset-store provider APIs, aligning this module with upstream Debezium changes (follow-up to debezium/debezium#7377).
Changes:
- Replace
KafkaConnectUtil.memoryOffsetBackingStore()with aKafkaMemoryOffsetProvider-based in-memory offset store. - Update test imports to use
KafkaConnectOffsetStoreAdapterandKafkaMemoryOffsetProvider.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/test/java/io/debezium/connector/vitess/VitessConnectorTest.java |
Replaces in-memory offset store creation to remove dependency on KafkaConnectUtil. |
src/test/java/io/debezium/connector/vitess/VitessConnectorTaskTest.java |
Updates task test context helper to use the new offset provider instead of KafkaConnectUtil. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Map<String, ?> serverOffsets, Map<String, Map<String, ?>> taskOffsets, | ||
| Function<Configuration.Builder, Configuration.Builder> customConfig) { | ||
| final OffsetBackingStore offsetStore = KafkaConnectUtil.memoryOffsetBackingStore(); | ||
| final OffsetBackingStore offsetStore = ((KafkaConnectOffsetStoreAdapter) (new KafkaMemoryOffsetProvider()).create(null)).getDelegate(); |
Comment on lines
1916
to
1918
| ContextHelper() { | ||
| this.offsetStore = KafkaConnectUtil.memoryOffsetBackingStore(); | ||
| this.offsetStore = ((KafkaConnectOffsetStoreAdapter) (new KafkaMemoryOffsetProvider()).create(null)).getDelegate(); | ||
| this.sourceConnectorContext = initSourceConnectorContext(); |
Comment on lines
+221
to
224
| this.offsetStore = ((KafkaConnectOffsetStoreAdapter) (new KafkaMemoryOffsetProvider()).create(null)).getDelegate(); | ||
| this.sourceTaskContext = initSourceTaskContext(); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of debezium/debezium#7377