Switch to towncrier to automatically manage the change log#1389
Conversation
- Added towncrier as a development dependency - Configured towncrier in `pyproject.toml`, adding supported types. - Updated `Makefile` with two commands, `make changes-draft` to see the draft of what would be output, and `make changes` to update `CHANGES.rst` and remove the change log entries from `/news` - Created a `/news` directory with `.gitkeep` file to keep the directory around. - Converted existing change log entries in `CHANGES.rst` to compliant change log entries in `/news` - Updated Contribute documentation section with new instructions for "Create a change log entry" and explain what makes a good entry. - Updated Maintenance documentation, replacing and removing obsolete manual steps with a single command of `make changes`. - Fixed link in `tests.yml` GitHub workflow to the change log. - Updated `pull_request_template.md` with link to the updated contributor documentation. Closes #1256.
Documentation build overview
4 files changed± 404.html± contribute/index.html± contribute/maintenance.html± reference/changelog.html |
Coverage Report for CI Build 25952817338Coverage remained the same at 97.775%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
SashankBhamidi
left a comment
There was a problem hiding this comment.
The PR description says "Created a /news directory with .gitkeep file to keep the directory around", but ls news/ shows no .gitkeep. After release, the directory will be empty and untracked by git.
Thanks. I thought it would get detected, but I needed to That should address all your points. One more review please, @SashankBhamidi? |
|
Thanks! Just one still open: the maintenance.rst The Issue/#PR label thing I raised on pyproject.toml is cosmetic, feel free to skip if you're happy with towncrier's default. |
Co-authored-by: Sashank <hello@sashank.wiki>
|
@SashankBhamidi one more review, please. Ignore any issues in |
Upstream switched to towncrier-managed CHANGES.rst in collective#1389 and cut release 7.1.1. Resolved the CHANGES.rst conflict by accepting upstream's regenerated file and migrating this PR's change log entry to a towncrier fragment at news/1370.bugfix per the new contributor workflow (docs/contribute/index.rst).
Closes issue
Closes #1256.
Description
pyproject.toml, adding supported types.Makefilewith two commands,make changes-draftto see the draft of what would be output, andmake changesto updateCHANGES.rstand remove the change log entries from/news/newsdirectory with.gitkeepfile to keep the directory around.CHANGES.rstto compliant change log entries in/newsmake changes.tests.ymlGitHub workflow to the change log.pull_request_template.mdwith link to the updated contributor documentation.Checklist
CHANGES.rst/news.Additional information
Check out this branch and run:
Output
📚 Documentation preview 📚: https://icalendar--1389.org.readthedocs.build/