Add ical_value property to vMonth#1381
Closed
xxiaoxiong wants to merge 1 commit into
Closed
Conversation
- Add ical_value property with type hints and docstring - Returns the underlying int value (month number) - Supports both regular and leap months (RFC 7529) - Add comprehensive tests for ical_value (8 test cases) - All tests pass - Code formatted with ruff Relates to collective#876
Member
|
@xxiaoxiong thank you for opening this PR. Because you haven't responded to the reviews and CI failures, I'm closing all of your PRs to let other contributors know that they are free to work on it. You're welcome to address our comments, resolve the matters, and reopen your pull request at any time, specifically to address the question of AI usage and add a change log, per Contribute. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
ical_valueproperty tovMonth, contributing to Issue #876.Changes
ical_valueproperty tovMonth(src/icalendar/prop/recur/month.py)int- The month numberint5545#section-3.3.10and :rfc:7529.leapproperty to check leap statusTests
test_vMonth.pywith 8 comprehensive test cases:test_ical_value_basic- Tests basic month numbertest_ical_value_all_months- Tests all 12 monthstest_ical_value_leap_month- Tests leap month (RFC 7529)test_ical_value_from_string- Tests string inputtest_ical_value_from_ical- Tests parsed ical stringstest_ical_value_january- Tests January (1)test_ical_value_december- Tests December (12)test_ical_value_arithmetic- Tests arithmetic operationsQuality Checks
Relates to #876