Add ical_value property to vWeekday#1379
Open
xxiaoxiong wants to merge 1 commit into
Open
Conversation
- Add ical_value property with type hints and docstring - Returns the underlying string value - Handles simple weekdays and relative positions - Add comprehensive tests for ical_value (7 test cases) - All tests pass - Code formatted with ruff Relates to collective#876
xxiaoxiong
requested review from
SashankBhamidi,
angatha,
niccokunzmann and
stevepiercy
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
ical_valueproperty tovWeekday, contributing to Issue #876.Changes
ical_valueproperty tovWeekday(src/icalendar/prop/recur/weekday.py)str- The weekday string valuestr5545#section-3.3.10Tests
test_vWeekday.pywith 7 comprehensive test cases:test_ical_value_simple_weekday- Tests simple weekdaytest_ical_value_all_weekdays- Tests all 7 weekday abbreviationstest_ical_value_positive_relative- Tests positive relative positiontest_ical_value_negative_relative- Tests negative relative positiontest_ical_value_from_ical- Tests with parsed ical stringstest_ical_value_case_insensitive- Tests case handlingtest_ical_value_with_plus_sign- Tests explicit plus signQuality Checks
Relates to #876