Add ical_value property to vTime#1372
Open
xxiaoxiong wants to merge 1 commit into
Open
Conversation
- Add ical_value property with type hints and docstring - Returns the underlying datetime.time object - Add comprehensive tests for ical_value (3 test cases) - All tests pass - Code formatted with ruff Relates to collective#876
Collaborator
|
Question from #1368 remains: Are you familiar with our contributing guidelines especially the part about artifical Intelligence? |
Member
I'm not comfortable reviewing a bunch of spam PRs opened right after one another. |
Member
|
@xxiaoxiong would you fix the test and add a change log entry? We'll close PRs after they've been open a week without addressing the failing checks. This applies for all PRs that you opened almost a week ago. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
ical_valueproperty tovTime, contributing to Issue #876.Changes
ical_valueproperty tovTime(src/icalendar/prop/dt/time.py)datetime.time- The underlying Python time objecttime5545#section-3.3.12Tests
test_vTime.pywith 3 comprehensive test cases:test_ical_value_local_time- Tests local time without timezonetest_ical_value_utc_time- Tests UTC time with timezonetest_ical_value_from_ical- Tests with parsed ical stringsQuality Checks
Relates to #876