Avoid implicit file reads from string calendar input#1362
Open
uwezkhan wants to merge 4 commits into
Open
Conversation
Documentation build overview
15 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens
Component.from_ical()by removing ambiguous string-path handling.Previously, a newline-free
strpassed tofrom_ical()was treated as a possible filesystem path. If that path existed, the parser read the file contents automatically. This made it easy for applications that pass untrusted strings intoCalendar.from_ical()/Component.from_ical()to accidentally allow local file reads or file-content disclosure through parser errors.After this change:
Pathinput still reads an iCalendar file explicitly.bytesandstrinput are treated only as iCalendar payload data.