Add type hints to vFrequency#1358
Open
arjunrawal1 wants to merge 2 commits into
Open
Conversation
Refs collective#938 Assisted-by: OpenAI Codex
Refs collective#938 Assisted-by: OpenAI Codex
stevepiercy
requested changes
May 5, 2026
Member
stevepiercy
left a comment
There was a problem hiding this comment.
Thanks for the PR! Let me know what you think.
|
|
||
| @classmethod | ||
| def from_ical(cls, ical): | ||
| def from_ical(cls, ical: Any) -> Self: |
Member
There was a problem hiding this comment.
Same as above.
Suggested change
| def from_ical(cls, ical: Any) -> Self: | |
| def from_ical(cls, ical: ICAL_TYPE) -> Self: |
| cls, | ||
| value, | ||
| encoding=DEFAULT_ENCODING, | ||
| value: Any, |
Member
There was a problem hiding this comment.
I think the use of Any is too loose. We have a special variable that you can import. Try this out, and let me know.
Modify the import.
from icalendar.parser_tools import DEFAULT_ENCODING, ICAL_TYPE, to_unicodeThen:
Suggested change
| value: Any, | |
| value: ICAL_TYPE, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vFrequency.__new__,to_ical, andfrom_ical.Refs #938
Testing
python3 -m pytest src/icalendar/tests/prop/test_constructors.py src/icalendar/tests/prop/test_unit.py src/icalendar/tests/rfc_7265_jcal/test_invalid_jcal.py -q— 751 passedNote: I also tried
python3 -m mypy src/icalendar/prop/recur/frequency.py, but mypy is not installed in this local environment.