Skip to content

chore: Add certificate export option#92

Merged
Igor Rodionov (goruha) merged 7 commits into
cloudposse:mainfrom
rankin-tr:rankin-tr/add-export-option
Jul 30, 2025
Merged

chore: Add certificate export option#92
Igor Rodionov (goruha) merged 7 commits into
cloudposse:mainfrom
rankin-tr:rankin-tr/add-export-option

Conversation

@rankin-tr
Copy link
Copy Markdown
Contributor

@rankin-tr rankin-tr commented Jul 30, 2025

@rankin-tr rankin-tr requested review from a team as code owners July 30, 2025 15:27
@mergify mergify Bot added the triage Needs triage label Jul 30, 2025
@goruha
Copy link
Copy Markdown
Member

Igor Rodionov (goruha) commented Jul 30, 2025

rankin-tr pls update versions.tf to pin minimal aws provider version to >= 6.4.0

https://registry.terraform.io/providers/hashicorp/aws/6.4.0/docs/resources/acm_certificate#options-configuration-block

@goruha
Copy link
Copy Markdown
Member

Igor Rodionov (goruha) commented Jul 30, 2025

rankin-tr also could you please add descriptions to this outputs

parent_zone_id is missing a description
parent_zone_name is missing a description
zone_fqdn is missing a description
zone_id is missing a description
zone_name is missing a description

https://github.com/cloudposse/terraform-aws-acm-request-certificate/blob/main/examples/complete/outputs.tf

Thanks

@goruha
Copy link
Copy Markdown
Member

Igor Rodionov (goruha) commented Jul 30, 2025

/terratest

@goruha
Copy link
Copy Markdown
Member

Igor Rodionov (goruha) commented Jul 30, 2025

/terratest

@goruha
Copy link
Copy Markdown
Member

Igor Rodionov (goruha) commented Jul 30, 2025

/terratest

1 similar comment
@goruha
Copy link
Copy Markdown
Member

Igor Rodionov (goruha) commented Jul 30, 2025

/terratest

@goruha
Copy link
Copy Markdown
Member

Igor Rodionov (goruha) commented Jul 30, 2025

/terratest

@mergify mergify Bot removed the triage Needs triage label Jul 30, 2025
@goruha Igor Rodionov (goruha) merged commit 82f2dbc into cloudposse:main Jul 30, 2025
26 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 30, 2025

These changes were released in v0.18.1.

@shaik-razak Shaik Razak (shaik-razak) mentioned this pull request Aug 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goruha Igor Rodionov (goruha) goruha approved these changes

@hans-d Hans Donner (hans-d) Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@kevcube Kevin (kevcube) Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

+1 more reviewer

@milldr Dan Miller (milldr) milldr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@goruha Igor Rodionov (goruha)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rankin-tr @goruha @milldr