Remove deprecated windows note from WindowSizeMsg docstr#1695
Open
Jaeiya wants to merge 1 commit into
Open
Conversation
meowgorithm
approved these changes
May 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
=======================================
Coverage 55.64% 55.64%
=======================================
Files 25 25
Lines 1310 1310
=======================================
Hits 729 729
Misses 491 491
Partials 90 90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
We added the ability for Windows to detect terminal size changes a very long time ago, and it should work for both Windows 10 and 11. Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is no longer an issue for all windows versions or just windows 10 & 11. I can only confirm 10 & 11. Let me know if there are any other considerations that need to be added or if we can just remove the note entirely, like I've done.
CONTRIBUTING.md.