fix(release-plz): cascade rust crate bumps into wasm crate#53
Merged
Conversation
Add a `version` field to the wasm crate's dep on the rust crate (via workspace.dependencies for centralization). release-plz uses changes to a dependent's manifest as the trigger for cascading version bumps; a path-only dep with no version field gives it nothing to edit, so wasm's version stayed frozen while rust bumped. PR #52 surfaced this — rust went 0.0.13 -> 0.0.14 but wasm/Cargo.toml + wasm/package.json stayed at 0.0.13, so the npm package would have shipped a stale version. With this change release-plz will update the workspace.dependencies version on each release, which cascades into a wasm crate bump, which the existing sync step in release-plz.yml mirrors into wasm/package.json. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
conwayconstar
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the gap that surfaced on #52, where release-plz bumped
rust/Cargo.tomlto0.0.14but leftwasm/Cargo.tomlandwasm/package.jsonat0.0.13— the existing sync step then "synced"wasm/package.jsonto the (stale) wasm crate version.release-plz cascades a bump from crate A → crate B by editing B's manifest (the
version = "..."constraint on its dep on A). With a path-only dep (bullet-rust-sdk = { path = "../rust" }), there's no version field to edit → no manifest change → no cascade → no wasm bump.This PR adds a versioned path dep via
workspace.dependenciesso the version lives in one place and release-plz maintains it:On every release PR going forward:
rust/Cargo.tomlworkspace.dependencies.bullet-rust-sdk.versionto matchwasm/Cargo.tomlrelease-plz.ymlmirrors that intowasm/package.jsonv<version>tag triggersnpm-publish.ymlagainst an@bulletxyz/sdk-wasmat the correct versionTest plan
cargo check --workspacecleanrust/Cargo.toml,wasm/Cargo.toml,wasm/package.json, and theworkspace.dependenciesversion, all to the same value🤖 Generated with Claude Code
Note
Low Risk
Low risk: only Cargo manifest dependency metadata changes to improve automated version bumping; no runtime code or build logic is modified beyond dependency resolution.
Overview
Ensures
release-plzcan cascade version bumps from the Rust crate into the WASM crate by introducing a versioned path dependency forbullet-rust-sdkin workspaceCargo.toml.Updates
wasm/Cargo.tomlto consumebullet-rust-sdkviaworkspace = trueinstead of a path-only dep, so the dependency version constraint is maintained centrally and will change on release PRs.Reviewed by Cursor Bugbot for commit 41cb070. Bugbot is set up for automated code reviews on this repo. Configure here.