Skip to content

[release-0.25] fix(e2e): Clear stale bootstrap IP annotation in bare metal API upgrade flow#10652

Merged
snarkychef merged 1 commit into
aws:release-0.25from
eks-distro-pr-bot:cherry-pick-10651-to-release-0.25
Feb 27, 2026
Merged

[release-0.25] fix(e2e): Clear stale bootstrap IP annotation in bare metal API upgrade flow#10652
snarkychef merged 1 commit into
aws:release-0.25from
eks-distro-pr-bot:cherry-pick-10651-to-release-0.25

Conversation

@eks-distro-pr-bot
Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #10651

/assign snarkychef

…de flow

The CLI-generated config file is written before the bootstrap-to-management
cluster pivot, so it retains the tinkerbell-bootstrap-ip annotation. When
the test re-applies this config via kubectl apply, the annotation gets
re-added to the Cluster CR, causing the controller to regenerate machine
templates with the bootstrap IP instead of the tinkerbellIP. This creates
a template diff that triggers unintended rollouts, blocking reconciliation.
@eks-distro-bot
Copy link
Copy Markdown
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@snarkychef
Copy link
Copy Markdown
Member

/ok-to-test
/lgtm
/approve

@eks-distro-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: snarkychef

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-0.25@c970db4). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.25   #10652   +/-   ##
===============================================
  Coverage                ?   69.60%           
===============================================
  Files                   ?      670           
  Lines                   ?    40923           
  Branches                ?        0           
===============================================
  Hits                    ?    28483           
  Misses                  ?    10707           
  Partials                ?     1733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snarkychef snarkychef merged commit 67ed536 into aws:release-0.25 Feb 27, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants