feat(dafny): Add bucket beacon support#1943
Conversation
Comment out the numberOfPartitions setting for two StandardBeacons.
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
|
@ajewellamz and @josecorella, I noticed you are updating the smithy model files. |
lucasmcdonald3
left a comment
lucasmcdonald3
left a comment
There was a problem hiding this comment.
Approving on Jose's behalf to unblock merge, I haven't reviewed these changes
|
@ajewellamz and @lucasmcdonald3, I noticed you are updating the smithy model files. |
josecorella
left a comment
josecorella
left a comment
There was a problem hiding this comment.
@mahnushm I also see that there are no rust examples, are we merging those after this PR lands but before launch?
| operation GetPartitionNumber { | ||
| input: GetPartitionNumberInput, | ||
| output: GetPartitionNumberOutput, | ||
| } | ||
|
|
||
| //= specification/searchable-encryption/search-config.md#partition-selector | ||
| //= type=implication | ||
| //# GetPartitionNumber MUST take as input | ||
| //# | ||
| //# - A DynamoDB Item (i.e an AttributeMap) | ||
| //# - The [number of partitions](#max-partitions) defined in the associated [beacon version](#beacon-version-initialization). | ||
| //# - The logical table name for this defined in the associated [table config](../dynamodb-encryption-client/ddb-table-encryption-config.md#structure). | ||
|
|
||
| structure GetPartitionNumberInput { | ||
| @required | ||
| item: AttributeMap, | ||
| @required | ||
| numberOfPartitions : PartitionCount, | ||
| @required | ||
| logicalTableName: String, | ||
| } | ||
|
|
||
| //= specification/searchable-encryption/search-config.md#partition-selector | ||
| //= type=implication | ||
| //# GetPartitionNumber MUST return | ||
| //# | ||
| //# - The number of the partition to use for this item | ||
|
|
||
| structure GetPartitionNumberOutput { | ||
| @required | ||
| partitionNumber: PartitionNumber | ||
| } | ||
|
|
There was a problem hiding this comment.
this operation and new structures have no javadocs annotations,should we add some @mahnushm?
(I also realize that the javadoc annotation is only supported in java afaik but it would be useful to add)
| var keyId :- Filter.GetBeaconKeyId(search.value.curr(), req.KeyConditionExpression, req.FilterExpression, req.ExpressionAttributeValues, req.ExpressionAttributeNames); | ||
| var oldContext := Filter.ExprContext(req.KeyConditionExpression, req.FilterExpression, req.ExpressionAttributeValues, req.ExpressionAttributeNames); | ||
| var newContext :- Filter.Beaconize(search.value.curr(), oldContext, keyId); | ||
| var foo :- ExtractPartition(search.value.curr(), req.FilterExpression, req.KeyConditionExpression, req.ExpressionAttributeNames, req.ExpressionAttributeValues, actions); |
There was a problem hiding this comment.
@rishav-karanjit, did you resolve this? does it need to be addressed before merging?
| for i : uint64 := 0 to |values| as uint64 | ||
| invariant result <= bv.numPartitions | ||
| { | ||
| var partitions := values[i].0.getNumQueries(bv.numPartitions, values[0].1); |
There was a problem hiding this comment.
did this get answered?
| structure GetNumberOfQueriesInput { | ||
| @required | ||
| input: QueryInput | ||
| } | ||
|
|
||
| //= specification/dynamodb-encryption-client/ddb-get-number-of-queries.md#input | ||
| //= type=implication | ||
| //# This operation MUST return the number of queries necessary. | ||
| structure GetNumberOfQueriesOutput { | ||
| @required | ||
| numberOfQueries: PartitionCount | ||
| } |
There was a problem hiding this comment.
these dont have javadocs
|
@ajewellamz and @josecorella, I noticed you are updating the smithy model files. |
7 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.