Skip to content

change tryGet() API misuse to Defect #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
etan-status wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

change tryGet() API misuse to Defect #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion results.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ func raiseResultError[T, E](self: Result[T, E]) {.noreturn, noinline.} =

when E is ref Exception:
if self.eResultPrivate.isNil: # for example Result.default()!
raise (ref ResultError[void])(msg: "Trying to access value with err (nil)")
raise (ref ResultDefect)(msg: "Trying to access value with err (nil)")
raise self.eResultPrivate
elif E is void:
raise (ref ResultError[void])(msg: "Trying to access value with err")
Expand Down