Skip to content

[TIR] Fixup max/min with input containing NAN #19589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
actinks wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −2
Open

[TIR] Fixup max/min with input containing NAN #19589

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
169eafa
[TIR] Fixup max/min with input containing NAN
actinks May 19, 2026
5559523
add llvm version macro
actinks May 19, 2026
2340aeb
del TVM_LLVM_VERSION >= 120, since bumped minimum llvm 150
actinks May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/target/llvm/codegen_llvm.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1598,13 +1598,21 @@ llvm::Value* CodeGenLLVM::VisitExpr_(const ModNode* op) {
llvm::Value* CodeGenLLVM::VisitExpr_(const MinNode* op) {
llvm::Value* a = MakeValue(op->a);
llvm::Value* b = MakeValue(op->b);
return builder_->CreateSelect(CreateLT(op->a.dtype(), a, b), a, b);
if (op->a.dtype().is_int() || op->a.dtype().is_uint()) {
return builder_->CreateSelect(CreateLT(op->a.dtype(), a, b), a, b);
} else {
return builder_->CreateMinimum(a, b);
}
Comment thread
actinks marked this conversation as resolved.
Outdated
}

llvm::Value* CodeGenLLVM::VisitExpr_(const MaxNode* op) {
llvm::Value* a = MakeValue(op->a);
llvm::Value* b = MakeValue(op->b);
return builder_->CreateSelect(CreateGT(op->a.dtype(), a, b), a, b);
if (op->a.dtype().is_int() || op->a.dtype().is_uint()) {
return builder_->CreateSelect(CreateGT(op->a.dtype(), a, b), a, b);
} else {
return builder_->CreateMaximum(a, b);
}
Comment thread
actinks marked this conversation as resolved.
Outdated
}

llvm::Value* CodeGenLLVM::VisitExpr_(const EQNode* op) {
Expand Down
Loading