[Relax] Normalize negative concat axis in ReorderPermuteDimsAfterConcat#19588
Draft
cchung100m wants to merge 3 commits into
Draft
[Relax] Normalize negative concat axis in ReorderPermuteDimsAfterConcat#19588cchung100m wants to merge 3 commits into
cchung100m wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the reorder_permute_dims_after_concat.cc file to implement axis normalization and bounds checking for concatenation operations. A critical issue was identified where the new implementation was added alongside the old one, resulting in variable redefinitions and a compilation error.
ReorderPermuteDimsAfterConcat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Committers,
This PR fixes #19575.
Root Cause
ReorderPermuteDimsAfterConcatreadsconcataxis and uses it as an index into the permutation axes.When
concat(axis=-1)is used, the negative axis was converted directly tosize_tbefore indexing, which can produce an out-of-range index and crash (e.g.IndexError: Index -1 out of bounds 4).Solution
In
src/relax/transform/reorder_permute_dims_after_concat.cc:axis += ndim.This keeps behavior unchanged for non-negative axes and only fixes negative-axis handling.